Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update modeling deps #4426

Merged
merged 1 commit into from
Jul 22, 2024
Merged

deps: update modeling deps #4426

merged 1 commit into from
Jul 22, 2024

Conversation

barmac
Copy link
Collaborator

@barmac barmac commented Jul 17, 2024

Closes #4335
Closes #4383
Closes #4394

Proposed Changes

This updates dependencies:

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@barmac barmac requested review from a team, philippfromme and marstamm and removed request for a team July 17, 2024 15:22
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jul 17, 2024
@barmac barmac requested a review from jarekdanielak July 17, 2024 15:22
@barmac
Copy link
Collaborator Author

barmac commented Jul 17, 2024

image

@barmac
Copy link
Collaborator Author

barmac commented Jul 17, 2024

To verify #4383 and #4394, you can use the a11y checker plugin: https://github.com/bpmn-io/camunda-modeler-plugin-a11y-checker/

Copy link
Contributor

@jarekdanielak jarekdanielak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all 3 things, looks good. 👍

  • no UI freeze on deselecting many elements
  • no accessibility violation on popup
  • correct accessibility attributes on drill down button

@barmac barmac merged commit 691c07f into develop Jul 22, 2024
15 checks passed
@barmac barmac deleted the update-modeling-deps-2024-07-17 branch July 22, 2024 11:47
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 22, 2024
@github-actions github-actions bot added this to the M79 milestone Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants