Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mixpanel): add formFieldTypes to diagram closed event #3954

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

pinussilvestrus
Copy link
Contributor

@pinussilvestrus pinussilvestrus commented Nov 1, 2023

Closes #3132
Related to https://github.com/camunda/team-hto/issues/350

This updates the desktopModeler:diagram:closed event with formFieldTypes in case a Form was closed. We run the element type collection recursively as we can have nested forms nowadays.

Example:

"formFieldTypes": {
  "textfield": 6,
  "group": 2,
  "image": 4 
}

@pinussilvestrus pinussilvestrus requested review from christian-konrad, RomanKostka, volodymyr-melnykc, a team, smbea and barmac and removed request for a team November 1, 2023 09:22
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Nov 1, 2023
Copy link
Member

@marstamm marstamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, let's track it 🚂

Copy link
Contributor

@christian-konrad christian-konrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pinussilvestrus pinussilvestrus merged commit 5b762e2 into develop Nov 2, 2023
14 checks passed
@pinussilvestrus pinussilvestrus deleted the 3132-track-form-fields branch November 2, 2023 12:19
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 2, 2023
@pinussilvestrus
Copy link
Contributor Author

Updated the docs via camunda/camunda-docs#2846

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider tracking for individual form-js elements
4 participants