Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formal parameters suggestions are not reloaded until view is reopened #4544

Closed
barmac opened this issue Sep 24, 2024 · 2 comments · Fixed by #4620
Closed

Formal parameters suggestions are not reloaded until view is reopened #4544

barmac opened this issue Sep 24, 2024 · 2 comments · Fixed by #4620
Assignees
@abdul99ahad
Labels
bug Something isn't working DMN
Milestone
M83

Comments

@barmac
Copy link
Collaborator

barmac commented Sep 24, 2024

Describe the bug

Variables are only loaded when you open the BKM, so you need to reopen the view after you add the formal parameters:

Screen.Recording.2024-09-19.at.16.57.49.mov

Steps to reproduce

  1. Create a BKM
  2. Add formal parameters
  3. Try to use the suggestions

Expected behavior

Suggestions are always up to date.

Environment

  • OS: [e.g. MacOS 10.2, Windows 10]
  • Camunda Modeler Version: [e.g. 2.0.0]
  • Execution Platform: [e.g. Camunda 7, Camunda 8]
  • Installed plug-ins: [...]

Additional context

Initially reported in bpmn-io/dmn-js#896
@barmac barmac added bug Something isn't working DMN labels Sep 24, 2024
@barmac
Copy link
Collaborator Author

barmac commented Sep 24, 2024

This is not a regression. The bug was present when BKM modeling was introduced.

@barmac barmac added the ready Ready to be worked on label Sep 25, 2024 — with bpmn-io-tasks
@barmac barmac mentioned this issue Sep 25, 2024
Closed
@abdul99ahad abdul99ahad added the in progress Currently worked on label Oct 15, 2024 — with bpmn-io-tasks
@abdul99ahad abdul99ahad removed the ready Ready to be worked on label Oct 15, 2024
@abdul99ahad abdul99ahad added the needs review Review pending label Nov 5, 2024 — with bpmn-io-tasks
@abdul99ahad abdul99ahad removed the in progress Currently worked on label Nov 5, 2024
@barmac
Copy link
Collaborator Author

barmac commented Nov 14, 2024

Fixed upstream in bpmn-io/dmn-js#914

@barmac barmac added fixed upstream Requires integration of upstream change and removed needs review Review pending labels Nov 14, 2024
abdul99ahad added a commit that referenced this issue Nov 19, 2024
@abdul99ahad
fix: formal parameters sync
ac74a2a 
Closes #4544
abdul99ahad added a commit that referenced this issue Nov 19, 2024
@abdul99ahad
fix: formal parameters sync
0fa9dc6 
Closes #4544
@abdul99ahad abdul99ahad mentioned this issue Nov 19, 2024
Closed
4 tasks
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Nov 19, 2024
abdul99ahad added a commit that referenced this issue Nov 19, 2024
@abdul99ahad
fix: formal parameters sync
4e52d91 
Closes #4544
abdul99ahad added a commit that referenced this issue Nov 20, 2024
@abdul99ahad
fix: formal parameters sync
bf71bd4 
Closes #4544
@nikku nikku mentioned this issue Nov 20, 2024
Merged
17 tasks
@nikku nikku added this to the M83 milestone Nov 21, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abdul99ahad abdul99ahad

Labels
bug Something isn't working DMN
Projects
None yet
Milestone
M83
3 participants
@nikku @barmac @abdul99ahad