Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Larger element names reduces the icon size in variables tab #4505

Closed
GeethaParthasarathy opened this issue Sep 6, 2024 · 6 comments · Fixed by #4696
Closed

Larger element names reduces the icon size in variables tab #4505

GeethaParthasarathy opened this issue Sep 6, 2024 · 6 comments · Fixed by #4696
Assignees
Labels
bug Something isn't working data handling good first issue Good for newcomers spring cleaning Could be cleaned up one day ui
Milestone

Comments

@GeethaParthasarathy
Copy link

GeethaParthasarathy commented Sep 6, 2024

Describe the bug

When we have larger text names the icon of the actvitiy/event gets shrunk in the variables tab

Steps to reproduce

  1. Create a activity/event with a larger name that has input/output variables
  2. Open the variables tab
  3. We could see that the icon size of the respective element is shrunk with the length of the name
Screen.Recording.2024-09-06.at.11.21.36.mov

Expected behavior

Larger element names could be cut short by adding ellipsis

Environment

  • OS: [MacOS 10.2]
  • Camunda Modeler Version: [5.27.0]
  • Execution Platform: [Camunda 8]

Additional context

No response

@GeethaParthasarathy GeethaParthasarathy added the bug Something isn't working label Sep 6, 2024
@GeethaParthasarathy GeethaParthasarathy changed the title Larger elemnt names reduces the icon size in variables tab Larger element names reduces the icon size in variables tab Sep 6, 2024
@nikku nikku added data handling ux good first issue Good for newcomers ui spring cleaning Could be cleaned up one day and removed ux labels Sep 26, 2024
@nikku
Copy link
Member

nikku commented Oct 1, 2024

This needs a fix in the variable outline project.

@nikku nikku added the backlog Queued in backlog label Oct 1, 2024
@abdul99ahad abdul99ahad self-assigned this Oct 30, 2024
@abdul99ahad abdul99ahad added the fixed upstream Requires integration of upstream change label Oct 30, 2024
@abdul99ahad abdul99ahad added the in progress Currently worked on label Oct 30, 2024 — with bpmn-io-tasks
@abdul99ahad abdul99ahad removed backlog Queued in backlog fixed upstream Requires integration of upstream change labels Oct 30, 2024
@misiekhardcore
Copy link
Contributor

Is ellipsis the right approach here?
If so shouldn't we display the full name on hover (with title prop for example?
Or should we simply block shrinking the icon element?

@misiekhardcore
Copy link
Contributor

Also I can see another problem, when the name is really long, it not only overflows the element list, but also it does not fit in the element on the diagram. Is this something what should also be addressed?
Screenshot from 2024-10-31 10-21-29

@abdul99ahad
Copy link
Contributor

Is ellipsis the right approach here? If so shouldn't we display the full name on hover (with title prop for example? Or should we simply block shrinking the icon element?

We are also doing the same in Problems tab and it doesn't display full element name on hover so imo, the variable tab should behave the same.
Screenshot 2024-11-04 at 20 00 19

@abdul99ahad
Copy link
Contributor

Also I can see another problem, when the name is really long, it not only overflows the element list, but also it does not fit in the element on the diagram. Is this something what should also be addressed? Screenshot from 2024-10-31 10-21-29

As mentioned in the PR, this is out of scope for variable outline. This needs fix in diagram-js. Feel free to open the issue.

@abdul99ahad abdul99ahad added the needs review Review pending label Nov 11, 2024 — with bpmn-io-tasks
@abdul99ahad abdul99ahad removed the in progress Currently worked on label Nov 11, 2024
@nikku nikku added the fixed upstream Requires integration of upstream change label Nov 14, 2024 — with bpmn-io-tasks
@nikku nikku removed the needs review Review pending label Nov 14, 2024
@nikku
Copy link
Member

nikku commented Nov 14, 2024

@abdul99ahad Let's go forth and integrate the upstream fix, closing this issue.

abdul99ahad added a commit that referenced this issue Nov 14, 2024
fixed upstream

Closes #4505
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Nov 14, 2024
abdul99ahad added a commit that referenced this issue Nov 18, 2024
fixed upstream

Closes #4505
nikku pushed a commit that referenced this issue Nov 19, 2024
fix: prevent long variable names from shrinking icon

  Closes #4505
nikku pushed a commit that referenced this issue Nov 19, 2024
fix: prevent long element names from shrinking icon

  Closes #4505
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 19, 2024
@github-actions github-actions bot modified the milestone: M83 Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data handling good first issue Good for newcomers spring cleaning Could be cleaned up one day ui
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants