Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup uses incorrect attribute name aria-role instead of role #4383

Closed
barmac opened this issue Jun 19, 2024 · 1 comment · Fixed by #4426
Closed

Popup uses incorrect attribute name aria-role instead of role #4383

barmac opened this issue Jun 19, 2024 · 1 comment · Fixed by #4426
Assignees
Labels
a11y bug Something isn't working
Milestone

Comments

@barmac
Copy link
Collaborator

barmac commented Jun 19, 2024

Describe the bug

The a11y-checker reports an incorrect attribute on the create/append popup. The used name is aria-role while role should be used:

report
{
  "id": "aria-valid-attr",
  "impact": "critical",
  "tags": [
    "cat.aria",
    "wcag2a",
    "wcag412",
    "EN-301-549",
    "EN-9.4.1.2"
  ],
  "description": "Ensures attributes that begin with aria- are valid ARIA attributes",
  "help": "ARIA attributes must conform to valid names",
  "helpUrl": "https://dequeuniversity.com/rules/axe/4.9/aria-valid-attr?application=axeAPI",
  "nodes": [
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry selected\" data-id=\"append-exclusive-gateway\" title=\"Exclusive gateway\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[data-id=\"append-exclusive-gateway\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-parallel-gateway\" title=\"Parallel gateway\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\"><div class=\"djs-popup-entry-content\"><span class=\"djs-popup-entry-name bpmn-icon-gateway-parallel\"><span class=\"djs-popup-label\">Parallel gateway</span></span></div></li>",
      "target": [
        "li[data-id=\"append-parallel-gateway\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-event-based-gateway\" title=\"Event-based gateway\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[data-id=\"append-event-based-gateway\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-task\" title=\"Task\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\"><div class=\"djs-popup-entry-content\"><span class=\"djs-popup-entry-name bpmn-icon-task\"><span class=\"djs-popup-label\">Task</span></span></div></li>",
      "target": [
        "li[data-id=\"append-task\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-user-task\" title=\"User task\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\"><div class=\"djs-popup-entry-content\"><span class=\"djs-popup-entry-name bpmn-icon-user\"><span class=\"djs-popup-label\">User task</span></span></div></li>",
      "target": [
        "li[data-id=\"append-user-task\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-service-task\" title=\"Service task\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\"><div class=\"djs-popup-entry-content\"><span class=\"djs-popup-entry-name bpmn-icon-service\"><span class=\"djs-popup-label\">Service task</span></span></div></li>",
      "target": [
        "li[data-id=\"append-service-task\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-rule-task\" title=\"Business rule task\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\"><div class=\"djs-popup-entry-content\"><span class=\"djs-popup-entry-name bpmn-icon-business-rule\"><span class=\"djs-popup-label\">Business rule task</span></span></div></li>",
      "target": [
        "li[data-id=\"append-rule-task\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-script-task\" title=\"Script task\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\"><div class=\"djs-popup-entry-content\"><span class=\"djs-popup-entry-name bpmn-icon-script\"><span class=\"djs-popup-label\">Script task</span></span></div></li>",
      "target": [
        "li[data-id=\"append-script-task\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-call-activity\" title=\"Call activity\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\"><div class=\"djs-popup-entry-content\"><span class=\"djs-popup-entry-name bpmn-icon-call-activity\"><span class=\"djs-popup-label\">Call activity</span></span></div></li>",
      "target": [
        "li[data-id=\"append-call-activity\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-transaction\" title=\"Transaction\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\"><div class=\"djs-popup-entry-content\"><span class=\"djs-popup-entry-name bpmn-icon-transaction\"><span class=\"djs-popup-label\">Transaction</span></span></div></li>",
      "target": [
        "li[data-id=\"append-transaction\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-event-subprocess\" title=\"Event sub-process\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[data-id=\"append-event-subprocess\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-collapsed-subprocess\" title=\"Sub-process (collapsed)\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[data-id=\"append-collapsed-subprocess\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-expanded-subprocess\" title=\"Sub-process (expanded)\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[data-id=\"append-expanded-subprocess\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-none-intermediate-throwing\" title=\"Intermediate throw event\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[title=\"Intermediate throw event\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-none-end-event\" title=\"End event\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\"><div class=\"djs-popup-entry-content\"><span class=\"djs-popup-entry-name bpmn-icon-end-event-none\"><span class=\"djs-popup-label\">End event</span></span></div></li>",
      "target": [
        "li[data-id=\"append-none-end-event\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-message-intermediate-catch\" title=\"Message intermediate catch event\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "ul[data-group=\"events\"] > li[aria-role=\"button\"]:nth-child(3)"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-message-intermediate-throw\" title=\"Message intermediate throw event\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "ul[data-group=\"events\"] > li[aria-role=\"button\"]:nth-child(4)"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-timer-intermediate-catch\" title=\"Timer intermediate catch event\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[title=\"Timer intermediate catch event\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-escalation-intermediate-throw\" title=\"Escalation intermediate throw event\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[aria-role=\"button\"]:nth-child(6)"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-conditional-intermediate-catch\" title=\"Conditional intermediate catch event\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[aria-role=\"button\"]:nth-child(7)"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-link-intermediate-catch\" title=\"Link intermediate catch event\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[data-id=\"append-link-intermediate-catch\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-link-intermediate-throw\" title=\"Link intermediate throw event\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[data-id=\"append-link-intermediate-throw\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-compensation-intermediate-throw\" title=\"Compensation intermediate throw event\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[aria-role=\"button\"]:nth-child(10)"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-signal-intermediate-catch\" title=\"Signal intermediate catch event\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[aria-role=\"button\"]:nth-child(11)"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-signal-intermediate-throw\" title=\"Signal intermediate throw event\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[aria-role=\"button\"]:nth-child(12)"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-message-end\" title=\"Message end event\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\"><div class=\"djs-popup-entry-content\"><span class=\"djs-popup-entry-name bpmn-icon-end-event-message\"><span class=\"djs-popup-label\">Message end event</span></span></div></li>",
      "target": [
        "li[data-id=\"append-message-end\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-escalation-end\" title=\"Escalation end event\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[data-id=\"append-escalation-end\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-error-end\" title=\"Error end event\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\"><div class=\"djs-popup-entry-content\"><span class=\"djs-popup-entry-name bpmn-icon-end-event-error\"><span class=\"djs-popup-label\">Error end event</span></span></div></li>",
      "target": [
        "li[data-id=\"append-error-end\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-cancel-end\" title=\"Cancel end event\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\"><div class=\"djs-popup-entry-content\"><span class=\"djs-popup-entry-name bpmn-icon-end-event-cancel\"><span class=\"djs-popup-label\">Cancel end event</span></span></div></li>",
      "target": [
        "li[data-id=\"append-cancel-end\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-compensation-end\" title=\"Compensation end event\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[data-id=\"append-compensation-end\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-signal-end\" title=\"Signal end event\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\"><div class=\"djs-popup-entry-content\"><span class=\"djs-popup-entry-name bpmn-icon-end-event-signal\"><span class=\"djs-popup-label\">Signal end event</span></span></div></li>",
      "target": [
        "li[data-id=\"append-signal-end\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-terminate-end\" title=\"Terminate end event\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[data-id=\"append-terminate-end\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-message-boundary\" title=\"Message boundary event\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[data-id=\"append-message-boundary\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-timer-boundary\" title=\"Timer boundary event\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[data-id=\"append-timer-boundary\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-escalation-boundary\" title=\"Escalation boundary event\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[data-id=\"append-escalation-boundary\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-conditional-boundary\" title=\"Conditional boundary event\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[data-id=\"append-conditional-boundary\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-error-boundary\" title=\"Error boundary event\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[data-id=\"append-error-boundary\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-cancel-boundary\" title=\"Cancel boundary event\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[data-id=\"append-cancel-boundary\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-signal-boundary\" title=\"Signal boundary event\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[data-id=\"append-signal-boundary\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-compensation-boundary\" title=\"Compensation boundary event\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[data-id=\"append-compensation-boundary\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-non-interrupting-message-boundary\" title=\"Message boundary event (non-interrupting)\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[aria-role=\"button\"]:nth-child(28)"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-non-interrupting-timer-boundary\" title=\"Timer boundary event (non-interrupting)\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[aria-role=\"button\"]:nth-child(29)"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-non-interrupting-escalation-boundary\" title=\"Escalation boundary event (non-interrupting)\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[aria-role=\"button\"]:nth-child(30)"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-non-interrupting-conditional-boundary\" title=\"Conditional boundary event (non-interrupting)\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[aria-role=\"button\"]:nth-child(31)"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-non-interrupting-signal-boundary\" title=\"Signal boundary event (non-interrupting)\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[aria-role=\"button\"]:nth-child(32)"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-data-store-reference\" title=\"Data store reference\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[data-id=\"append-data-store-reference\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append-data-object-reference\" title=\"Data object reference\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[data-id=\"append-data-object-reference\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append.template-05d1c06a-b65d-428c-8ca0-10c14b3fb0ee\" title=\"AddItemExample\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[title=\"AddItemExample\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append.template-io.camunda.examples.ConditionalRestConnector\" title=\"(Conditional) REST Connector\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[title=\"(Conditional) REST Connector\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    },
    {
      "any": [
        {
          "id": "aria-valid-attr",
          "data": [
            "aria-role"
          ],
          "relatedNodes": [],
          "impact": "critical",
          "message": "Invalid ARIA attribute name: aria-role"
        }
      ],
      "all": [],
      "none": [],
      "impact": "critical",
      "html": "<li class=\"entry\" data-id=\"append.template-test\" title=\"Pattern\" tabindex=\"0\" aria-role=\"button\" draggable=\"true\">",
      "target": [
        "li[data-id=\"append.template-test\"]"
      ],
      "failureSummary": "Fix any of the following:\n  Invalid ARIA attribute name: aria-role"
    }
  ]
}

Steps to reproduce

  1. Use a11y-checker plugin
  2. Open popup menu
  3. now this happens

Expected behavior

No violation.

Environment

  • OS: [e.g. MacOS 10.2, Windows 10]
  • Camunda Modeler Version: [e.g. 2.0.0]
  • Execution Platform: [e.g. Camunda 7, Camunda 8]
  • Installed plug-ins: [...]

Additional context

No response

@barmac barmac added bug Something isn't working a11y ready Ready to be worked on labels Jun 19, 2024
@barmac barmac self-assigned this Jun 19, 2024
barmac added a commit to bpmn-io/diagram-js that referenced this issue Jun 21, 2024
@barmac
Copy link
Collaborator Author

barmac commented Jun 21, 2024

This will be fixed upstream via bpmn-io/diagram-js#918

barmac added a commit to bpmn-io/diagram-js that referenced this issue Jun 21, 2024
barmac added a commit to bpmn-io/diagram-js that referenced this issue Jun 21, 2024
@barmac barmac added the needs review Review pending label Jun 21, 2024 — with bpmn-io-tasks
@barmac barmac removed the ready Ready to be worked on label Jun 21, 2024
@barmac barmac added the fixed upstream Requires integration of upstream change label Jun 24, 2024 — with bpmn-io-tasks
@barmac barmac removed the needs review Review pending label Jun 24, 2024
barmac added a commit to bpmn-io/bpmn-js that referenced this issue Jun 25, 2024
fix: remove incorrect attribute in replace menu

Related to camunda/camunda-modeler#4383
nikku pushed a commit to bpmn-io/bpmn-js that referenced this issue Jun 26, 2024
fix: remove incorrect attribute in replace menu

Related to camunda/camunda-modeler#4383
barmac added a commit that referenced this issue Jul 17, 2024
@barmac barmac mentioned this issue Jul 17, 2024
4 tasks
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Jul 17, 2024
@barmac barmac closed this as completed in 691c07f Jul 22, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 22, 2024
@github-actions github-actions bot added this to the M79 milestone Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant