Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding possible configuration variables for identity and also linked it to the gateway configuration #4863

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

itsnuyen
Copy link

Description

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

Copy link
Contributor

github-actions bot commented Jan 16, 2025

👋 🤖 🤔 Hello, @itsnuyen! Did you make your changes in all the right places?

These files were changed only in versioned_docs/version-8.6/. You might want to duplicate these changes in docs/.

  • versioned_docs/version-8.6/self-managed/identity/deployment/configuration-variables.md
  • versioned_docs/version-8.6/self-managed/zeebe-deployment/configuration/gateway.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

itsnuyen and others added 4 commits January 17, 2025 08:47
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@jonathanlukas jonathanlukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good first iteration! Please reach out to me to discuss my comments :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will check whether and how identity will be configured in the core component of 8.7

@@ -27,6 +27,19 @@ As a Spring Boot application, Identity supports any standard
| `KEYCLOAK_SETUP_CLIENT_ID` | The client to use for authentication during setup of the provided Keycloak. | admin-cli |
| `KEYCLOAK_URL` | The URL of the Keycloak instance to use. | http://localhost:18080/auth |

## Camunda Identity Configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header can be misleading. Maybe "Camunda Identity SDK Configuration" would be better.

Suggested change
## Camunda Identity Configuration
## Camunda Identity SDK Configuration

@@ -27,6 +27,20 @@ As a Spring Boot application, Identity supports any standard
| `KEYCLOAK_SETUP_CLIENT_ID` | The client to use for authentication during setup of the provided Keycloak. | admin-cli |
| `KEYCLOAK_URL` | The URL of the Keycloak instance to use. | http://localhost:18080/auth |

## Camunda Identity Configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header can be misleading. Maybe "Camunda Identity SDK Configuration" would be better.

Suggested change
## Camunda Identity Configuration
## Camunda Identity SDK Configuration

@@ -27,6 +27,20 @@ As a Spring Boot application, Identity supports any standard
| `KEYCLOAK_SETUP_CLIENT_ID` | The client to use for authentication during setup of the provided Keycloak. | admin-cli |
| `KEYCLOAK_URL` | The URL of the Keycloak instance to use. | http://localhost:18080/auth |

## Camunda Identity Configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header can be misleading. Maybe "Camunda Identity SDK Configuration" would be better.

Suggested change
## Camunda Identity Configuration
## Camunda Identity SDK Configuration

@@ -251,7 +251,7 @@ security:

:::note
The Zeebe configuration properties for Camunda Identity are deprecated as of version `8.4.0`. Use the dedicated
Camunda Identity properties or the [corresponding environment variables](../../identity/deployment/configuration-variables.md#core-configuration).
Camunda Identity properties or the [corresponding environment variables](../../identity/deployment/configuration-variables.md#camunda-identity-configuration).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Camunda Identity properties or the [corresponding environment variables](../../identity/deployment/configuration-variables.md#camunda-identity-configuration).
Camunda Identity properties or the [corresponding environment variables](../../identity/deployment/configuration-variables.md#camunda-identity-sdk-configuration).

@@ -27,6 +27,19 @@ As a Spring Boot application, Identity supports any standard
| `KEYCLOAK_SETUP_CLIENT_ID` | The client to use for authentication during setup of the provided Keycloak. | admin-cli |
| `KEYCLOAK_URL` | The URL of the Keycloak instance to use. | http://localhost:18080/auth |

## Camunda Identity Configuration

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a small section that explains that these properties are used to configure the identity connection for each camunda component

@@ -27,6 +27,20 @@ As a Spring Boot application, Identity supports any standard
| `KEYCLOAK_SETUP_CLIENT_ID` | The client to use for authentication during setup of the provided Keycloak. | admin-cli |
| `KEYCLOAK_URL` | The URL of the Keycloak instance to use. | http://localhost:18080/auth |

## Camunda Identity Configuration

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a small section that explains that these properties are used to configure the identity connection for each camunda component

@@ -27,6 +27,20 @@ As a Spring Boot application, Identity supports any standard
| `KEYCLOAK_SETUP_CLIENT_ID` | The client to use for authentication during setup of the provided Keycloak. | admin-cli |
| `KEYCLOAK_URL` | The URL of the Keycloak instance to use. | http://localhost:18080/auth |

## Camunda Identity Configuration

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a small section that explains that these properties are used to configure the identity connection for each camunda component


| Environment Variable | Property | Description | Default Value |
| --------------------------------- | ---------------- | --------------------------------------------------------------------------------------------------------------------------------- | -------------------------- |
| CAMUNDA_IDENTITY_ISSUERBACKENDURL | issuerBackendUrl | The URL to the auth provider backend, used to validate tokens. This setting can also be overridden using the environment variable | - |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Property" should always contain the full path:

Suggested change
| CAMUNDA_IDENTITY_ISSUERBACKENDURL | issuerBackendUrl | The URL to the auth provider backend, used to validate tokens. This setting can also be overridden using the environment variable | - |
| CAMUNDA_IDENTITY_ISSUERBACKENDURL | camunda.identity.issuerBackendUrl | The URL to the auth provider backend, used to validate tokens. This setting can also be overridden using the environment variable | - |

| Environment Variable | Property | Description | Default Value |
| --------------------------------- | ---------------- | --------------------------------------------------------------------------------------------------------------------------------- | -------------------------- |
| CAMUNDA_IDENTITY_ISSUERBACKENDURL | issuerBackendUrl | The URL to the auth provider backend, used to validate tokens. This setting can also be overridden using the environment variable | - |
| CAMUNDA_IDENTITY_AUDIENCE | audience | The required audience of the auth token. This setting can also be overridden using the environment variable | - |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The properties can be formatted as code to mark them.

Suggested change
| CAMUNDA_IDENTITY_AUDIENCE | audience | The required audience of the auth token. This setting can also be overridden using the environment variable | - |
| `CAMUNDA_IDENTITY_AUDIENCE` | `camunda.identity.audience` | The required audience of the auth token. This setting can also be overridden using the environment variable | - |

itsnuyen and others added 2 commits January 17, 2025 13:55
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants