-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding possible configuration variables for identity and also linked it to the gateway configuration #4863
base: main
Are you sure you want to change the base?
Conversation
…it to the gateway configuration
👋 🤖 🤔 Hello, @itsnuyen! Did you make your changes in all the right places? These files were changed only in versioned_docs/version-8.6/. You might want to duplicate these changes in docs/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…the updated configuration parameters
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good first iteration! Please reach out to me to discuss my comments :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will check whether and how identity will be configured in the core component of 8.7
@@ -27,6 +27,19 @@ As a Spring Boot application, Identity supports any standard | |||
| `KEYCLOAK_SETUP_CLIENT_ID` | The client to use for authentication during setup of the provided Keycloak. | admin-cli | | |||
| `KEYCLOAK_URL` | The URL of the Keycloak instance to use. | http://localhost:18080/auth | | |||
|
|||
## Camunda Identity Configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The header can be misleading. Maybe "Camunda Identity SDK Configuration" would be better.
## Camunda Identity Configuration | |
## Camunda Identity SDK Configuration |
@@ -27,6 +27,20 @@ As a Spring Boot application, Identity supports any standard | |||
| `KEYCLOAK_SETUP_CLIENT_ID` | The client to use for authentication during setup of the provided Keycloak. | admin-cli | | |||
| `KEYCLOAK_URL` | The URL of the Keycloak instance to use. | http://localhost:18080/auth | | |||
|
|||
## Camunda Identity Configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The header can be misleading. Maybe "Camunda Identity SDK Configuration" would be better.
## Camunda Identity Configuration | |
## Camunda Identity SDK Configuration |
@@ -27,6 +27,20 @@ As a Spring Boot application, Identity supports any standard | |||
| `KEYCLOAK_SETUP_CLIENT_ID` | The client to use for authentication during setup of the provided Keycloak. | admin-cli | | |||
| `KEYCLOAK_URL` | The URL of the Keycloak instance to use. | http://localhost:18080/auth | | |||
|
|||
## Camunda Identity Configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The header can be misleading. Maybe "Camunda Identity SDK Configuration" would be better.
## Camunda Identity Configuration | |
## Camunda Identity SDK Configuration |
@@ -251,7 +251,7 @@ security: | |||
|
|||
:::note | |||
The Zeebe configuration properties for Camunda Identity are deprecated as of version `8.4.0`. Use the dedicated | |||
Camunda Identity properties or the [corresponding environment variables](../../identity/deployment/configuration-variables.md#core-configuration). | |||
Camunda Identity properties or the [corresponding environment variables](../../identity/deployment/configuration-variables.md#camunda-identity-configuration). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Camunda Identity properties or the [corresponding environment variables](../../identity/deployment/configuration-variables.md#camunda-identity-configuration). | |
Camunda Identity properties or the [corresponding environment variables](../../identity/deployment/configuration-variables.md#camunda-identity-sdk-configuration). |
@@ -27,6 +27,19 @@ As a Spring Boot application, Identity supports any standard | |||
| `KEYCLOAK_SETUP_CLIENT_ID` | The client to use for authentication during setup of the provided Keycloak. | admin-cli | | |||
| `KEYCLOAK_URL` | The URL of the Keycloak instance to use. | http://localhost:18080/auth | | |||
|
|||
## Camunda Identity Configuration | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a small section that explains that these properties are used to configure the identity connection for each camunda component
@@ -27,6 +27,20 @@ As a Spring Boot application, Identity supports any standard | |||
| `KEYCLOAK_SETUP_CLIENT_ID` | The client to use for authentication during setup of the provided Keycloak. | admin-cli | | |||
| `KEYCLOAK_URL` | The URL of the Keycloak instance to use. | http://localhost:18080/auth | | |||
|
|||
## Camunda Identity Configuration | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a small section that explains that these properties are used to configure the identity connection for each camunda component
@@ -27,6 +27,20 @@ As a Spring Boot application, Identity supports any standard | |||
| `KEYCLOAK_SETUP_CLIENT_ID` | The client to use for authentication during setup of the provided Keycloak. | admin-cli | | |||
| `KEYCLOAK_URL` | The URL of the Keycloak instance to use. | http://localhost:18080/auth | | |||
|
|||
## Camunda Identity Configuration | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a small section that explains that these properties are used to configure the identity connection for each camunda component
|
||
| Environment Variable | Property | Description | Default Value | | ||
| --------------------------------- | ---------------- | --------------------------------------------------------------------------------------------------------------------------------- | -------------------------- | | ||
| CAMUNDA_IDENTITY_ISSUERBACKENDURL | issuerBackendUrl | The URL to the auth provider backend, used to validate tokens. This setting can also be overridden using the environment variable | - | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Property" should always contain the full path:
| CAMUNDA_IDENTITY_ISSUERBACKENDURL | issuerBackendUrl | The URL to the auth provider backend, used to validate tokens. This setting can also be overridden using the environment variable | - | | |
| CAMUNDA_IDENTITY_ISSUERBACKENDURL | camunda.identity.issuerBackendUrl | The URL to the auth provider backend, used to validate tokens. This setting can also be overridden using the environment variable | - | |
| Environment Variable | Property | Description | Default Value | | ||
| --------------------------------- | ---------------- | --------------------------------------------------------------------------------------------------------------------------------- | -------------------------- | | ||
| CAMUNDA_IDENTITY_ISSUERBACKENDURL | issuerBackendUrl | The URL to the auth provider backend, used to validate tokens. This setting can also be overridden using the environment variable | - | | ||
| CAMUNDA_IDENTITY_AUDIENCE | audience | The required audience of the auth token. This setting can also be overridden using the environment variable | - | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The properties can be formatted as code to mark them.
| CAMUNDA_IDENTITY_AUDIENCE | audience | The required audience of the auth token. This setting can also be overridden using the environment variable | - | | |
| `CAMUNDA_IDENTITY_AUDIENCE` | `camunda.identity.audience` | The required audience of the auth token. This setting can also be overridden using the environment variable | - | |
…s well as formating
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Description
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).