Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document job result in Job Workers concept page #4813

Open
wants to merge 1 commit into
base: 26342-user-task-listeners-concept
Choose a base branch
from

Conversation

ce-dmelnych
Copy link
Contributor

@ce-dmelnych ce-dmelnych commented Jan 2, 2025

Description

Scope:

  • Added a short section on job results in completing or failing jobs.
  • Linked to the User task listeners concept page
  • Added note that job result is used for the user task listeners only right now.

These changes were made together by @ana-vinogradova-camunda and @ce-dmelnych so they don't require additional Engineering review. A Technical writer review is appreciated.

closes camunda/camunda#26344

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

Copy link
Contributor

github-actions bot commented Jan 2, 2025

👋 🤖 🤔 Hello, @ce-dmelnych! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.

  • docs/components/concepts/job-workers.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@ce-dmelnych ce-dmelnych added 8.7.0-alpha3 January 2024 alpha release deploy Stand up a temporary docs site with this PR labels Jan 2, 2025
@ce-dmelnych ce-dmelnych requested a review from a team January 2, 2025 11:53
@ce-dmelnych ce-dmelnych marked this pull request as ready for review January 2, 2025 11:53
@ce-dmelnych ce-dmelnych linked an issue Jan 2, 2025 that may be closed by this pull request
@github-actions github-actions bot temporarily deployed to camunda-docs January 2, 2025 12:05 Destroyed
- Added a short section on job results in `completing or failing jobs`.
- Linked to the `User task listeners` concept page
- Added note that job result is used for the user task listeners only right now.

Co-authored-by: Ana Vinogradova <[email protected]>
@ce-dmelnych ce-dmelnych force-pushed the 26344-job-workers-document-job-result branch from f0b6578 to 30a6955 Compare January 2, 2025 14:33
@github-actions github-actions bot temporarily deployed to camunda-docs January 2, 2025 14:46 Destroyed
Copy link
Contributor

github-actions bot commented Jan 2, 2025

The preview environment relating to the commit b0ae4ad has successfully been deployed. You can access it at https://preview.docs.camunda.cloud/pr-4813/index.html

@ce-dmelnych ce-dmelnych changed the title docs: document job result in Job Workers concept page Document job result in Job Workers concept page Jan 3, 2025
@korthout korthout self-requested a review January 7, 2025 15:26
Copy link
Member

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

🔧 Just one small suggestion

Job results are used to define:

1. **Corrections**: Updates to specific user task attributes, such as assignee, due date, follow-up date, candidate users, candidate groups, and priority, before the task transition is finalized. For more details, see [Correcting user task data](components/concepts/user-task-listeners.md/#correcting-user-task-data).
2. **Denial**: Indicates that the operation should be explicitly denied. Denying an operation prevents the task lifecycle transition and discards any corrections made by previous listeners. For more details, see [Denying the operation](components/concepts/user-task-listeners.md/#denying-the-operation).
Copy link
Member

@korthout korthout Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to other documentation about the topic, let's refer to task lifecycle transition rather than operation.

Suggested change
2. **Denial**: Indicates that the operation should be explicitly denied. Denying an operation prevents the task lifecycle transition and discards any corrections made by previous listeners. For more details, see [Denying the operation](components/concepts/user-task-listeners.md/#denying-the-operation).
2. **Denial**: Indicates that the lifecycle transition should be explicitly denied. Denying the task lifecycle transition rolls back the user task to the previous state, and discards any corrections made by previous listeners. For more details, see [Denying the operation](components/concepts/user-task-listeners.md/#denying-the-operation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.7.0-alpha3 January 2024 alpha release deploy Stand up a temporary docs site with this PR
Projects
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

Document job results in Job Workers concept page
3 participants