Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(flaky): change tomcat port for XTaC IT #4759

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix(flaky): change tomcat port for XTaC IT #4759

merged 1 commit into from
Dec 2, 2024

Conversation

mboskamp
Copy link
Member

@mboskamp mboskamp commented Nov 1, 2024

@mboskamp mboskamp added the ci:skipTests Skips tests execution in Assembly and Distro-ee stages. label Nov 1, 2024
@mboskamp mboskamp self-assigned this Nov 1, 2024
@mboskamp
Copy link
Member Author

mboskamp commented Nov 1, 2024

Switched to ports in the 50xxx range because those can not be registered for services: https://en.wikipedia.org/wiki/List_of_TCP_and_UDP_port_numbers#Dynamic,_private_or_ephemeral_ports

@mboskamp mboskamp removed the ci:skipTests Skips tests execution in Assembly and Distro-ee stages. label Nov 6, 2024
@mboskamp mboskamp added the ci:jdk Runs the builds for all supported Java versions. label Nov 15, 2024
@mboskamp mboskamp force-pushed the 87-xtac-port-in-use branch from bdf24b8 to eabf73e Compare November 15, 2024 12:19
yanavasileva
yanavasileva approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@yanavasileva yanavasileva left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The CI ran 3 times, no failures. Let's merge it.

❓ Shall we also backport the changes 7.20-7.22?

@mboskamp mboskamp added bot:backport:7.20 Backports PR to maintenance branch 7.20. bot:backport:7.21 Backports PR to maintenance branch 7.21. bot:backport:7.22 labels Dec 2, 2024
@mboskamp
Copy link
Member Author

mboskamp commented Dec 2, 2024

❓ Shall we also backport the changes 7.20-7.22?

I added the backport labels. Let's see how this goes 😁

@mboskamp mboskamp marked this pull request as ready for review December 2, 2024 12:39
@mboskamp mboskamp merged commit 01f92ac into master Dec 2, 2024
11 checks passed
@mboskamp mboskamp deleted the 87-xtac-port-in-use branch December 2, 2024 12:39
@ap-development-workflow
Copy link

Successfully created backport PR for 7.20:

  • camunda/camunda-bpm-platform-maintenance#1330

@ap-development-workflow
Copy link

Successfully created backport PR for 7.21:

  • camunda/camunda-bpm-platform-maintenance#1331

@ap-development-workflow
Copy link

Successfully created backport PR for 7.22:

  • camunda/camunda-bpm-platform-maintenance#1332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanavasileva yanavasileva yanavasileva approved these changes

Assignees

@mboskamp mboskamp

Labels
bot:backport:7.20 Backports PR to maintenance branch 7.20. bot:backport:7.21 Backports PR to maintenance branch 7.21. bot:backport:7.22 ci:jdk Runs the builds for all supported Java versions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mboskamp @yanavasileva