feat(connect): upgrade to apache httpclient 5.x #4408

[strangelookingnerd]

Re-created from #4408

related to #4438

[yanavasileva]

Hi @strangelookingnerd,

Thank you for raising the PR.
I will get to it in the next weeks. But before that I will trigger our tests so I can give you early feedback on this.

Best,
Yana

[yanavasileva]

@strangelookingnerd, I wanted to trigger the tests against this branch but the build is failing.
Could you have a look at it? In repo root:

mvn -s clean source:jar deploy source:test-jar com.mycila:license-maven-plugin:check -Pdistro,distro-ce,distro-wildfly,distro-webjar,h2-in-memory

Error that I see:

[2024-10-07T16:41:53.918Z] [ERROR] 'dependencies.dependency.version' for org.apache.httpcomponents.client5:httpclient5:jar must be a valid version but is '${version.httpclient5}'. @ line 66, column 16
[2024-10-07T16:41:53.918Z]  @ 
[2024-10-07T16:41:53.918Z] [INFO] [jenkins-event-spy] Generated /home/jenkins/agent/workspace/23_cambpm-ce_cambpm-main_PR-4680@tmp/withMaven8784d992/maven-spy-20241007-184141-92116238138332426972134.log
[2024-10-07T16:41:53.918Z] [ERROR] The build could not read 2 projects -> [Help 1]
[2024-10-07T16:41:53.918Z] [ERROR]   
[2024-10-07T16:41:53.918Z] [ERROR]   The project org.camunda.bpm.springboot:camunda-bpm-spring-boot-starter-security:7.23.0-SNAPSHOT (/home/jenkins/agent/workspace/23_cambpm-ce_cambpm-main_PR-4680/spring-boot-starter/starter-security/pom.xml) has 1 error
[2024-10-07T16:41:53.918Z] [ERROR]     'dependencies.dependency.version' for org.apache.httpcomponents.client5:httpclient5:jar must be a valid version but is '${version.httpclient5}'. @ line 54, column 16
[2024-10-07T16:41:53.919Z] [ERROR]   
[2024-10-07T16:41:53.919Z] [ERROR]   The project org.camunda.bpm:camunda-external-task-client:7.23.0-SNAPSHOT (/home/jenkins/agent/workspace/23_cambpm-ce_cambpm-main_PR-4680/clients/java/client/pom.xml) has 1 error
[2024-10-07T16:41:53.919Z] [ERROR]     'dependencies.dependency.version' for org.apache.httpcomponents.client5:httpclient5:jar must be a valid version but is '${version.httpclient5}'. @ line 66, column 16
``

[strangelookingnerd]

@strangelookingnerd, I wanted to trigger the tests against this branch but the build is failing. Could you have a look at it?

I resolved the merge conflicts.

[yanavasileva]

Hi @strangelookingnerd,

There are some test failures related to the changes of this PR.
CamundaBpmSampleApplicationTest is failing in camunda-bpm-spring-boot-starter-security module (introduced in 7.22).
Could you please have a look? You can use the same command from my previous message to run the build.
I will start the review in my next working day. Thank you for your patience with this.

[strangelookingnerd]

Hi @strangelookingnerd,

There are some test failures related to the changes of this PR. CamundaBpmSampleApplicationTest is failing in camunda-bpm-spring-boot-starter-security module (introduced in 7.22). Could you please have a look? You can use the same command from my previous message to run the build. I will start the review in my next working day. Thank you for your patience with this.

Seems like there is a version mismatch for httpclient5 dependencies when using spring-boot-dependencies. Spring still relies on 5.3.1 which itself relies on 5.2.2 of httpcore5. This does not work with httpclient5 in 5.4.1 as I proposed and is causing tests to fail with

Caused by: java.lang.NoSuchMethodError: 'void org.apache.hc.core5.http.impl.io.DefaultHttpRequestWriterFactory.<init>(org.apache.hc.core5.http.config.Http1Config)'

Now there is two options:

1. override all of the related dependencies from spring-boot-dependencies
2. simply rely on the same version spring-boot-dependencies provides

In my experience the second option will cause way less headache further down the road. I downgraded the <version.httpclient> property to 5.3.1 to match spring-boot-dependencies. This way the build runs succesfully. There is hope that a more recent version of spring-boot-dependencies will at some point also use the newer versions of httpclient5 and httpcore5.