Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove(core): remove easy telemetry #4486

Merged
merged 44 commits into from
Aug 20, 2024
Merged

remove(core): remove easy telemetry #4486

merged 44 commits into from
Aug 20, 2024

Conversation

yanavasileva
Copy link
Member

@yanavasileva yanavasileva added ci:e2e Runs the frontend end-to-end tests. ci:all-as Runs the builds for all application servers. ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels). ci:migration Runs the process instance migration builds. ci:no-build Prevents any CI stage from running. ci:rest-api Runs extra builds for the REST API (currently only WLS compatibility builds). ci:rolling-update Runs the rolling update builds. ci:spring-boot Runs the integration tests for the Spring Boot starter. ci:webapp-integration Runs the webapp integration builds. labels Jul 8, 2024
@yanavasileva yanavasileva self-assigned this Jul 8, 2024
@yanavasileva yanavasileva mentioned this pull request Jul 8, 2024
Closed
18 tasks
@yanavasileva yanavasileva added ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels). ci:e2e Runs the frontend end-to-end tests. ci:all-as Runs the builds for all application servers. ci:migration Runs the process instance migration builds. ci:rolling-update Runs the rolling update builds. ci:webapp-integration Runs the webapp integration builds. and removed ci:no-build Prevents any CI stage from running. ci:e2e Runs the frontend end-to-end tests. ci:all-as Runs the builds for all application servers. ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels). ci:migration Runs the process instance migration builds. ci:rolling-update Runs the rolling update builds. ci:webapp-integration Runs the webapp integration builds. ci:spring-boot Runs the integration tests for the Spring Boot starter. labels Jul 8, 2024
@yanavasileva yanavasileva force-pushed the 4234-remove-telemetry branch 3 times, most recently from e1d23bb to 85aba6b Compare July 15, 2024 09:05
@yanavasileva yanavasileva marked this pull request as ready for review July 16, 2024 15:00
@yanavasileva
clean up tests
f40d243
@yanavasileva
remove exclude
1045f16
@yanavasileva
remove InternalsImpl.telemetryEnabled
c663246
@yanavasileva
clean telemetry configuration and get diagnostic tests
6464e09
@yanavasileva
add supppress
c033978
@yanavasileva
fix typo
8188d1a
@yanavasileva
TMP run api by default
b9063ad
@yanavasileva
clean up TODO
431c6ee
@yanavasileva
adjust OpenAPI
38cc0b2
@yanavasileva
fix rest api mock
675a539
@yanavasileva
remove TelemetryRegistry#telemetryLocallyActivated
7c5ea9d 
remove TelemetryUtil#toggleLocalTelemetry
@yanavasileva
telemetry sending task
24148ee 
*remove timer & cleanup #updateAndSendData
* rename to DiagnosticsCollector
@yanavasileva
add guava (previously transitive to wiremock)
44086d6
@yanavasileva
remove telemetry reporter
b8379e9
@yanavasileva
renaming telemetry -> diagnostics
95cdd25 
TelemetryRegistry -> DiagnosticsRegistry
PlatformTelemetryRegistry -> PlatformDiagnosticsRegistry
CommandChecker.checkReadDiagnosticsData ->
CommandChecker.checkReadTelemetryData
DeleteLicenseKeyCmd.updateTelemetry ->
DeleteLicenseKeyCmd.updateDiagnostics
ManagementServiceImpl.getLicenseKeyFromTelemetry() ->
ManagementServiceImpl.getLicenseKeyFromDiagnostics()

remove

* Telemetry logger
* ManagementServiceImpl.clearTelemetryData()
@yanavasileva
move
0e2d657 
org.camunda.bpm.engine.impl.telemetry.reporter.DiagnosticsCollector ->
org.camunda.bpm.engine.impl.telemetry.DiagnosticsCollector

org.camunda.bpm.engine.impl.telemetry.JavaClases ->
org.camunda.bpm.engine.impl.diagnostics
@yanavasileva
remove telemetry in distro/run and spring-boot-starter
2e4db56
@yanavasileva
fix imports
46297f3
@yanavasileva
move registry to Impl
282568a
@yanavasileva
remove logger
ac187d7
@yanavasileva
remove telemetry.lock
034da74
@yanavasileva
implement review hints
fbceb35
@yanavasileva
revert Jenkinsfile
0541025
@yanavasileva
Copy link
Member Author

Unreviewed commits before rebase:

  • implement review hints
  • revert Jenkinsfile

@yanavasileva yanavasileva force-pushed the 4234-remove-telemetry branch from 857594e to 0541025 Compare August 14, 2024 07:37
@yanavasileva
Copy link
Member Author

The failures observed in the PR are present on the master as well.

joaquinfelici
joaquinfelici approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@joaquinfelici joaquinfelici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks for implementing suggestions 👍

@yanavasileva yanavasileva merged commit aa1f15b into master Aug 20, 2024
2 of 4 checks passed
@yanavasileva yanavasileva deleted the 4234-remove-telemetry branch August 20, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquinfelici joaquinfelici joaquinfelici approved these changes

Assignees

@yanavasileva yanavasileva

Labels
ci:all-as Runs the builds for all application servers. ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels). ci:e2e Runs the frontend end-to-end tests. ci:migration Runs the process instance migration builds. ci:rest-api Runs extra builds for the REST API (currently only WLS compatibility builds). ci:rolling-update Runs the rolling update builds. ci:webapp-integration Runs the webapp integration builds.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yanavasileva @joaquinfelici