Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] server_environment: Migration to 18.0 #2

Closed

Conversation

thienvh332
Copy link

@thienvh332 thienvh332 commented Sep 26, 2024

This PR migration will consist of 2 parts:

1. Sync:
Synchronized missing commits from branch 14.0 to 17.0 for the server_environment module. Used the oca-port tool to check for missing commits. You can verify this by running the following command:

oca-port origin/14.0 origin/17.0 server_environment --verbose

Ported PRs:
- #159

2. Migrate:
After syncing, migrated the server_environment module to v18.

Changes:
- Cleaned TODO tags

jgrandguillaume and others added 30 commits September 24, 2024 12:37
(lp:c2c-addons/6.1  rev 11)
(lp:c2c-addons/6.1  rev 28.1.1)
…t is the blessed target.

(lp:c2c-addons/6.1  rev 40.2.1)
(lp:c2c-addons/6.1  rev 45.1.4)
…TK client, because for 6.1 the web client is the blessed target.

(lp:c2c-addons/6.1  rev 116)
This fixes OCA/server-tools#125 because in some Ubuntu systems
lsb_release outputs to stderr as well as stdout. This message will be
printed to console, not logged nor shown among server infomation. That
way the message is lost and only pollutes unit tests output.
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
* [IMP] load server environment options from odoo rcfile

This allows delivering the code with default configuration options for
all environments in the server_environment_file module, but letting
the administrator override some configuration entries in the regular
odoo configuration file.

* server_environment_file: update README
To trigger rebuild following change in setup.py
qgroulard and others added 25 commits September 24, 2024 12:37
Not all fields have their string in the args, but '.string' returns the computed (based on field name) string if not set in the args.
Currently translated at 6.5% (7 of 107 strings)

Translation: server-env-16.0/server-env-16.0-server_environment
Translate-URL: https://translation.odoo-community.org/projects/server-env-16-0/server-env-16-0-server_environment/it/
Currently translated at 65.4% (70 of 107 strings)

Translation: server-env-16.0/server-env-16.0-server_environment
Translate-URL: https://translation.odoo-community.org/projects/server-env-16-0/server-env-16-0-server_environment/es/
Currently translated at 100.0% (107 of 107 strings)

Translation: server-env-16.0/server-env-16.0-server_environment
Translate-URL: https://translation.odoo-community.org/projects/server-env-16-0/server-env-16-0-server_environment/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-env-17.0/server-env-17.0-server_environment
Translate-URL: https://translation.odoo-community.org/projects/server-env-17-0/server-env-17-0-server_environment/
Currently translated at 100.0% (107 of 107 strings)

Translation: server-env-17.0/server-env-17.0-server_environment
Translate-URL: https://translation.odoo-community.org/projects/server-env-17-0/server-env-17-0-server_environment/es/
Currently translated at 100.0% (107 of 107 strings)

Translation: server-env-17.0/server-env-17.0-server_environment
Translate-URL: https://translation.odoo-community.org/projects/server-env-17-0/server-env-17-0-server_environment/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-env-17.0/server-env-17.0-server_environment
Translate-URL: https://translation.odoo-community.org/projects/server-env-17-0/server-env-17-0-server_environment/
Currently translated at 100.0% (106 of 106 strings)

Translation: server-env-17.0/server-env-17.0-server_environment
Translate-URL: https://translation.odoo-community.org/projects/server-env-17-0/server-env-17-0-server_environment/sv/
Since previous commit adding support for ssl certificate auth,
field smtp_authentication in ir.mail_server, became a field managed by
environment, when mail_environment is installed.

This field has been defined using a default value relying on the
compute_default property allowing to define a compute function,
which matches the default value of the field.

However, as the function _compute_server_env_from_default was broken,
because it did not assign the computed value to the field, the
field was empty and connection was broken.
Revert "server_environment: Fix value assignation in compute from default"

This reverts commit 464f3ec which would
break other modules using server_environment.

The original issue must be fixed in mail_environment.
@thienvh332 thienvh332 marked this pull request as draft September 26, 2024 09:20
@thienvh332 thienvh332 marked this pull request as ready for review September 26, 2024 09:43
@simahawk simahawk closed this Oct 10, 2024
@simahawk
Copy link
Member

OCA#204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.