Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Add a params.pp file #59

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add a params.pp file #59

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
82fc829
Add a params.pp file, to allow OS specific differences to be set
buzzdeee Sep 11, 2015
d75c797
Add a binary_indicator parameter for the usage of $digest_string.
buzzdeee Sep 21, 2015
88fb2cf
Fixup, for Solaris
buzzdeee Aug 30, 2016
e8bf214
Include is enough, and fail if parameter/class not found
buzzdeee Sep 1, 2016
7e53669
try require
buzzdeee Sep 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifests/extract.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
$tar_command=$::archive::params::tarcmd,
) {

include ::archive::params
require ::archive::params
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no resources in params, so include will do just the same as require.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not exactly sure about that one. Does an include enforce order of evaluation?

the require ensures ::archive::params is evaluated before the extract.pp is evaluated, so that the
values of ::archive::params::FOOBAR are available, when used later in the defined type, does the
include enforce the same?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're mixing up order of parsing and order of evaluation.

Parsing is done on the master side, always top-down.

Evaluation is done on the agent, based on the catalog, and following the dependency tree based on either implicit or explicit dependencies between resources.

The params class has no resources at all, only variables, so there's no need for evaluation ordering. Variables will be available if they have been parsed before, which is true if you included the class already.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, really. include is all you need. If it fails, it must be another reason.


if $root_dir {
$extract_dir = "${target}/${root_dir}"
Expand Down