Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile and README.md to help development #35

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Stegallo
Copy link

No description provided.

@vinayak-mehta
Copy link
Member

Thanks for the PR @Stegallo! I'll test it out and merge soon.

docker/README.md Outdated Show resolved Hide resolved
docker/README.md Outdated
... and modify the [webserver] section as:

<pre>
web_server_host = 0.0.0.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For production use should probably include instructions on using a WSGI server or similar

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point... the initial idea behind having a the docker container is for development purpose, but I agree if we want to use the a container for deployment this may need a thing to address

Copy link

@zainozzaini zainozzaini Feb 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any instruction for WSGI setup ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@williamjacksn
Copy link
Contributor

For comparison, I made my own Dockerfile for this project here: https://github.com/williamjacksn/docker-excalibur

@Peque
Copy link

Peque commented May 31, 2020

@williamjacksn I tried your image and it works pretty well. 😊

Maybe open your own PR for inclusion? Since this PR seems to be abandoned.

@williamjacksn
Copy link
Contributor

As an example, I updated my docker-excalibur project to use a custom entrypoint instead of excalibur webserver and serve with waitress instead of Flask.

https://github.com/williamjacksn/docker-excalibur

@Stegallo
Copy link
Author

I've updated the docker file and created a docker compose to simplify starting up. The compose has also a nginx server that can be re-pointed once wsgi is implemented
thanks to @williamjacksn and @Lamaun for the hints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants