-
-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerfile and README.md to help development #35
base: master
Are you sure you want to change the base?
Conversation
Thanks for the PR @Stegallo! I'll test it out and merge soon. |
docker/README.md
Outdated
... and modify the [webserver] section as: | ||
|
||
<pre> | ||
web_server_host = 0.0.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For production use should probably include instructions on using a WSGI server or similar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point... the initial idea behind having a the docker container is for development purpose, but I agree if we want to use the a container for deployment this may need a thing to address
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any instruction for WSGI setup ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For comparison, I made my own Dockerfile for this project here: https://github.com/williamjacksn/docker-excalibur |
@williamjacksn I tried your image and it works pretty well. 😊 Maybe open your own PR for inclusion? Since this PR seems to be abandoned. |
As an example, I updated my docker-excalibur project to use a custom entrypoint instead of |
I've updated the docker file and created a docker compose to simplify starting up. The compose has also a nginx server that can be re-pointed once wsgi is implemented |
No description provided.