This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update API guidelines to add subscription/notification/event.md #173
Update API guidelines to add subscription/notification/event.md #173
Changes from 39 commits
be0c07b
564ab30
4913df9
acba31f
bcef981
dc5fc5e
17bdbe8
406e868
ec5767c
f47f279
274a1c6
83b991c
62fcfe1
b0a326f
3319e18
fb52c7e
99134ba
d288537
ffcdfd2
c98390c
c8d273b
d2402ec
86683ea
7d2b48f
160f6bb
67df8c4
47181d1
19e2ad2
1a8794b
5bd3f3d
e3445b2
9a30e72
64dbbc3
c83090e
8aea1b3
c732063
700fc9b
270599b
4b33bea
0773c27
cb6ab13
b4f0513
db37ee3
fa1496d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the event triggers the termination of the subscription , I believe , using an HTTP DELETE request to remove the subscription is good idea rather "POST".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sachinvodafone Here the notification did not trigger the termination. The notification informs the subscriber that the subscription is terminated. So this is an event and as such we use the POST notification operation.
Of course to delete a subscription we have the DELETE /event-subscriptions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The subject of "Example for subscription termination - Request:" was causing me confusion, but I find it acceptable if its purpose is only to inform the client about a termination that has already been executed/terminated through another action. Thank you.