Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tenure date format from date-time to date #17

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

eric-murray
Copy link
Contributor

What type of PR is this?

  • enhancement/feature

What this PR does / why we need it:

Commonalities now accepts format: date as a valid string format, so this PR changes the format of tenureDate from date-time to date.

Which issue(s) this PR fixes:

Fixes # N/A

Special notes for reviewers:

Commonalities now accept any registered format

Changelog input

 release-note
 - Change `tenureDate` format from `date-time` to `date`

Additional documentation

None

Copy link
Contributor

@fernandopradocabrillo fernandopradocabrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

Copy link

@GillesInnov35 GillesInnov35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok thanks

@eric-murray eric-murray merged commit 5e4f2bb into camaraproject:main Dec 16, 2024
2 checks passed
@eric-murray eric-murray deleted the eric-murray-patch-1 branch December 16, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants