Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error response schema to align with Commonalities #16

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

eric-murray
Copy link
Contributor

What type of PR is this?

  • enhancement/feature

What this PR does / why we need it:

  • Update error response schema to comply with updated templates in Commonalities CAMARA_common.yaml
  • Remove error codes INVALID_TOKEN_CONTEXT and NOT_FOUND
  • Rename UNAVAILABLE to SERVICE_UNAVAILABLE

Which issue(s) this PR fixes:

Fixes # N/A

Special notes for reviewers:

None

Changelog input

 release-note
 - Update error response schema to comply with updated Commonalities templates

Additional documentation

None

Copy link
Contributor

@fernandopradocabrillo fernandopradocabrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @eric-murray

Copy link

@GillesInnov35 GillesInnov35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Eric

@eric-murray eric-murray merged commit 88f3c51 into camaraproject:main Dec 17, 2024
2 checks passed
@eric-murray eric-murray deleted the eric-murray-patch-3 branch December 17, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants