-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EventSimSwap to Sim Swap Subscriptions #157
Conversation
@daniel-dierich Thanks - Yes we should fix this ! Are you able to manage EasyCLA with your company to LF? Thanks a lot for the contribution. We have to remove as well
(lines 681-685) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@daniel-dierich if you have issue/question related to easyCLA --> @wrathwolf can help. |
I have been added to the easyCLA of my company but I seem unable to restart the check. |
Perhaps it requires some time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@daniel-dierich Thanks for the PR! please could you also change the API version to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Adds the event for a sim swap to the API specification for sim-swap-subscriptions.
Which issue(s) this PR fixes:
Fixes #156