Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EventSimSwap to Sim Swap Subscriptions #157

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

daniel-dierich
Copy link
Contributor

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

Adds the event for a sim swap to the API specification for sim-swap-subscriptions.

Which issue(s) this PR fixes:

Fixes #156

Copy link

linux-foundation-easycla bot commented Oct 16, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@bigludo7
Copy link
Collaborator

bigludo7 commented Oct 16, 2024

@daniel-dierich Thanks - Yes we should fix this !

Are you able to manage EasyCLA with your company to LF?
If not let me know and I can craft the PR to fix this.

Thanks a lot for the contribution.

We have to remove as well

    Event-typeEvent:
      description: event structure for event-type event
      allOf:
        - $ref: "#/components/schemas/CloudEvent"
        - type: object

(lines 681-685)

bigludo7
bigludo7 previously approved these changes Oct 17, 2024
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bigludo7
Copy link
Collaborator

@daniel-dierich if you have issue/question related to easyCLA --> @wrathwolf can help.

@daniel-dierich
Copy link
Contributor Author

I have been added to the easyCLA of my company but I seem unable to restart the check.

@bigludo7
Copy link
Collaborator

I have been added to the easyCLA of my company but I seem unable to restart the check.

Perhaps it requires some time?
I'v send a check - only megalinter is checked.
BTW you have a trailing space un line 680 making megalinter unhappy.

bigludo7
bigludo7 previously approved these changes Oct 17, 2024
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fernandopradocabrillo
Copy link
Collaborator

@daniel-dierich Thanks for the PR!

please could you also change the API version to wip and the url server version to vwip?

Copy link
Collaborator

@fernandopradocabrillo fernandopradocabrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bigludo7 bigludo7 self-requested a review October 17, 2024 12:14
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bigludo7 bigludo7 merged commit 9e05324 into camaraproject:main Oct 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sim-Swap-Subscription]: EventSimSwap is missing
3 participants