Sim swap subscription test definition + adding 422 example for DEVICE_NOT_APPLICABLE #147
Conversation
Added 422 DeviceNotApplicable example
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Co-authored-by: Fernando Prado Cabrillo <[email protected]>
| And "$.config.subscriptionDetail.phoneNumber" is set with with provided phoneNumber | ||
| And "$.sink" is set to provided callbackUrl | ||
| Then the response property "$.status" is 201 | ||
| And the response header "Content-Type" is "application/json" |
There was a problem hiding this comment.
This applies to multiple scenarios
| And the response header "Content-Type" is "application/json" | |
| And the response header "Content-Type" is "application/json" | |
There was a problem hiding this comment.
Fixed. This strange because look good in visual studio and then did not reflect properly. Anyway fixed in github editor.
| And the response property "$.code" is "INVALID_ARGUMENT" | ||
| And the response property "$.message" contains a user friendly text | ||
|
|
||
| @sim_swap_subscription_delete_27_subscription_without_id |
There was a problem hiding this comment.
I have doubts with this test because if in the path I send a subscriptionId that doesn't exist or I don't send it at all it should be a 404 right? because it is in the path
There was a problem hiding this comment.
Yes you're right. I remove this one.
| And the response property "$.code" is "INVALID_TOKEN_CONTEXT" | ||
| And the response property "$.message" contains a user friendly text | ||
|
|
||
| @sim_swap_subscription_delete_61_device_token_mismatch |
There was a problem hiding this comment.
this one is duplicated
There was a problem hiding this comment.
The scenario is not duplicate but the number yes - kept the scenario & fixed the number
| And the response property "$.code" is "NOT_FOUND" | ||
| And the response property "$.message" contains a user friendly text | ||
|
|
||
| @sim_swap_subscription_delete_81_not_found_delete_by_id |
There was a problem hiding this comment.
this one is the one I was referring in the above comment, for me it seems correct this way
Co-authored-by: Fernando Prado Cabrillo <[email protected]>
Co-authored-by: Fernando Prado Cabrillo <[email protected]>
Co-authored-by: Fernando Prado Cabrillo <[email protected]>
Co-authored-by: Fernando Prado Cabrillo <[email protected]>
Updated after helpful @fernandopradocabrillo review
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Add test definition for sim swap subscription
Which issue(s) this PR fixes:
Fixes #145
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.