Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release PR for public release r1.2 (M4) #353

Merged
merged 20 commits into from
Sep 6, 2024

Conversation

hdamker
Copy link
Collaborator

@hdamker hdamker commented Aug 23, 2024

What type of PR is this?

Add one of the following kinds:

  • documentation
  • subproject management

What this PR does / why we need it:

Create the public release r1.2, see #352

Which issue(s) this PR fixes:

Fixes #352

Special notes for reviewers:

Changelog input

 Updates of file versions, CHANGELOG and README for public release

Target state for M4 assumed
Release notes for r1.2 including:
Editorial changes or some entries from r1.1
Added PR #335 which was missed to be mentioned in r1.1
Copy link

github-actions bot commented Aug 23, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ OPENAPI spectral 3 0 5.2s
✅ REPOSITORY git_diff yes no 0.06s
✅ REPOSITORY secretlint yes no 1.07s
✅ XML xmllint 1 0 0 0.07s
✅ YAML yamllint 3 0 0.83s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@hdamker hdamker changed the title Release PR public release r1.2 (M4) Release PR for public release r1.2 (M4) Aug 23, 2024
README.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@hdamker
Copy link
Collaborator Author

hdamker commented Aug 30, 2024

Added #356 proactively to CHANGELOG and updated the PR description.

@jlurien jlurien self-requested a review August 30, 2024 12:19
Clarification of "optional device object" within SessionInfo Description to address issue #340
@hdamker hdamker requested a review from a team August 30, 2024 18:42
@hdamker
Copy link
Collaborator Author

hdamker commented Aug 30, 2024

All PRs for v0.11.0 so far closed, adding @camaraproject/release-management_maintainers as reviewer.

@hdamker
Copy link
Collaborator Author

hdamker commented Aug 30, 2024

@jlurien @RandyLevensalor @eric-murray @tlohmar: I've addressed #340 here with e7bd701. Please have a look if that is ok for you.

@tanjadegroot
Copy link

I do not see the updated User Story file in this PR, but I have a comment on the Summary section:
"As an application developer belonging to an enterprise, I want to request (using my application server/backend service), stable latency and/or stable throughput for a specified App-Flow from a Communication Service Provider (CSP), so that I can ensure better quality of experience for our end users including under network congestion"

I would propose to drop the "from a Communication Service Provider (CSP)" as the app can also talk to an Aggregator.
Or would it be "for a specified App-Flow from a given device connected to the application through the network, so that ..." ?

Also suggest to drop the word "our" from "our end users".

@tanjadegroot
Copy link

I think you can remove the LICENCE.APACHE.2.0 file from the code/Test_definitions folder as it is already present in the main folder.

Copy link

@tanjadegroot tanjadegroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M4 release management review done: A few minor comments only
please check and then LGTM

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
code/API_definitions/quality-on-demand.yaml Outdated Show resolved Hide resolved
code/API_definitions/quality-on-demand.yaml Outdated Show resolved Hide resolved
code/API_definitions/quality-on-demand.yaml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@hdamker
Copy link
Collaborator Author

hdamker commented Sep 5, 2024

@tanjadegroot Thanks a lot for the intensive review. See my answer on your comments. Please have a view if ok for you. I have also deleted the duplicated license file (I recently added the file at the right place but have overseen that there was one in /code). For the User Story I don't see the changes as urgent and have kept it untouched (but I merged main into the PR branch, so that now the User Story is part of it).

@eric-murray @jlurien @RandyLevensalor please check the latest changes and approve the PR if ok for you.

@hdamker hdamker requested a review from tanjadegroot September 5, 2024 16:15
@hdamker
Copy link
Collaborator Author

hdamker commented Sep 6, 2024

@jlurien @eric-murray @RandyLevensalor I've addressed all review comments from Tanja, so from Release Management there is green light. But I can't merge the release PR without a Codeowner review.

Copy link
Collaborator

@RandyLevensalor RandyLevensalor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hdamker thanks for all of the updates and work on this!!

@tanjadegroot
Copy link

@tanjadegroot Thanks a lot for the intensive review. See my answer on your comments. Please have a view if ok for you. I have also deleted the duplicated license file (I recently added the file at the right place but have overseen that there was one in /code). For the User Story I don't see the changes as urgent and have kept it untouched (but I merged main into the PR branch, so that now the User Story is part of it).

Review done by RM: LGTM

@hdamker hdamker merged commit 2f7706b into main Sep 6, 2024
2 checks passed
@hdamker hdamker deleted the 352-create-pr-for-public-release-r12-m4 branch September 6, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create PR for public release r1.2 (M4)
4 participants