Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release r1.1 #336

Merged
merged 22 commits into from
Aug 9, 2024

Conversation

hdamker
Copy link
Collaborator

@hdamker hdamker commented Aug 6, 2024

What type of PR is this?

Add one of the following kinds:

  • subproject management

What this PR does / why we need it:

Prepare the release r1.1:

  • Update CHANGELOG.med
  • Update README.md
  • Set versions in quality-on-demand and qos-profiles
  • Set version in qos-provisioning (check all "wip", including event version)
  • Update API Readiness Checklists

Update - additional fixes

Which issue(s) this PR fixes:

Fixes #334 #338

Special notes for reviewers:

hdamker added 5 commits August 5, 2024 11:28
added the frame for r1.1, to be filled with change details
content for draft review
set the version number
set the version number
@hdamker
Copy link
Collaborator Author

hdamker commented Aug 6, 2024

@RandyLevensalor @jlurien have a look on the r1.1 section in CHANGELOG.md.

@hdamker
Copy link
Collaborator Author

hdamker commented Aug 7, 2024

Release PR is almost complete ... just waiting for the merge of #299 and the ability to set the version in the new API qos-provisioning to 0.1.0-rc.1

README.md Outdated Show resolved Hide resolved
@hdamker
Copy link
Collaborator Author

hdamker commented Aug 7, 2024

Replaced all "wip" in qod-provisioning.yaml:

  • in version and server field according to guidelines
  • in org.camaraproject.qod-provisioning.vwip.status-changed to org.camaraproject.qod-provisioning.v0.status-changed. My thoughts here:
    • There is no specific guideline for initial API versions, but other initial APIs have used here also v0 (e.g. in DeviceStatus)
    • The event version should be decoupled from the API version (as the API can have breaking changes, but keep the event structure stable) ... so if the event structure will change in a further initial API version we can still then use another number.
    • BTW: I would not reset to wip as long as there is no breaking change to the event structure within a PR. I would anyway expect that it is more probably that the event type guideline will change than the event structure.
  • in line 1087 ... set to the current base path v0.1, but it is only an example, wouldn't matter too much if we miss this one going forward

@hdamker hdamker marked this pull request as ready for review August 7, 2024 11:18
@hdamker
Copy link
Collaborator Author

hdamker commented Aug 7, 2024

@camaraproject/quality-on-demand_maintainers @camaraproject/release-management_maintainers
The release PR for r1.1 is now complete and ready for review.

Note: #325 has to be merged first before this PR can be merged and the release created.

@hdamker hdamker requested a review from a team August 7, 2024 11:20
Added changelog entries for PR camaraproject#318
jlurien
jlurien previously approved these changes Aug 8, 2024
Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated Show resolved Hide resolved
Co-authored-by: Eric Murray <[email protected]>
eric-murray
eric-murray previously approved these changes Aug 9, 2024
@hdamker hdamker added the Fall24 Relevant for maintenance of Fall24 release label Aug 9, 2024
Copy link
Contributor

@rartych rartych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@RandyLevensalor RandyLevensalor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hdamker hdamker merged commit 75c5beb into camaraproject:main Aug 9, 2024
1 check passed
@hdamker hdamker deleted the 334-prepare-release-pr-for-r11 branch August 9, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fall24 Relevant for maintenance of Fall24 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare release PR for r1.1
5 participants