Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignement with Spring25 #89

Merged
merged 13 commits into from
Jan 16, 2025
Merged

Alignement with Spring25 #89

merged 13 commits into from
Jan 16, 2025

Conversation

bigludo7
Copy link
Collaborator

@bigludo7 bigludo7 commented Dec 20, 2024

What type of PR is this?

Add one of the following kinds:

  • enhancement/feature

What this PR does / why we need it:

See #87

Which issue(s) this PR fixes:

Fixes #85 #86 #87 #88

Special notes for reviewers:

Changelog input

 release-note
- Make phoneNumber optional in send-code (no change for the consumer)
- Align x-correlator definition (no change for the consumer)
- Remove from the yaml the errors 406, 415, 500, 503 & 504 (no change for the consumer)
- Remove test cases for 406 & 415 (no change for the consumer)
- Restructure test cases (no change for the consumer)
- Fix test cases @OTPvalidationAPI_02_send_code_success_scenario_without_x-correlator and @OTPvalidationAPI_02_validate_code_sucess_scenario_without_x-correlator (no change for the consumer)
- Change error structure as defined in commonalities 0.5.0 (no change for the consumer)

Additional documentation

This section can be blank.

docs

Copy link

github-actions bot commented Dec 20, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ OPENAPI spectral 1 0 1.73s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 0.75s
✅ YAML yamllint 1 0 0.35s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@bigludo7
Copy link
Collaborator Author

@fernandopradocabrillo @jgarciahospital Accordingly to our discussion in #88 I've updated the yaml & Test Case.
Fernando if you can proceed to a last review to check if we're good. Thanks !

@bigludo7 bigludo7 merged commit b041849 into main Jan 16, 2025
2 checks passed
@bigludo7 bigludo7 deleted the spring25 branch January 16, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correction needed for API Test documentation
2 participants