Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct name of middleNames Match Score attribute in kyc-match yaml file #171

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GillesInnov35
Copy link
Collaborator

Correct name of middleNames Match Score attribute

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

Correct name of middleNames Match Score response attribute.
Replace middleNamesScore by middleNamesMatchScore

Which issue(s) this PR fixes:

Fixes ##161

Special notes for reviewers:

Changelog input

 release-note

Correct name of middleNames Match Score attribute
@GillesInnov35
Copy link
Collaborator Author

hi all, this update will break backward compatibility. So could be implemented only in a major version. WDYT
BR
Gilles

@HuubAppelboom
Copy link
Collaborator

hi all, this update will break backward compatibility. So could be implemented only in a major version. WDYT BR Gilles

For KPN no problem, we have not gone live yet with customers

@fernandopradocabrillo
Copy link
Collaborator

Thanks @GillesInnov35 for the PR. We are actually integrating clients with current version, so let me check the impact with my product team.

@GillesInnov35
Copy link
Collaborator Author

thanks @fernandopradocabrillo, yes there's an impact for current implementation using this attribute. It is not the case at Orange France but it could for others countries. So let's see impact to decide then if we delay this evolution to a major version I think.
BR
Gilles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants