Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HomeDevicesQoD Test Cases gherkin definition #53

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

jpengar
Copy link
Collaborator

@jpengar jpengar commented Aug 9, 2023

What type of PR is this?

Add one of the following kinds:

  • tests

What this PR does / why we need it:

This PR contributes to the definition of the HomeDevicesQoD API test case in gherkin format (.feature file) as agreed in camaraproject/WorkingGroups#61.

Which issue(s) this PR fixes:

It addresses Step 5 ("API test cases and documentation") in home_devices_qod_readiness_checklist.md, which is part of Issue #39, to generate a first stable v1.0.0 of the HomeDevicesQoD API. The process needs to comply with https://github.com/camaraproject/Commonalities/blob/main/documentation/API-Readiness-Checklist.md and a final Step 6 Tested by at least 2 operators would be required. Discussed in camaraproject/ReleaseManagement#16.

Special notes for reviewers:

N/A

Changelog input

 API test cases definition in gherkin format (.feature file)

Additional documentation

N/A

@jpengar
Copy link
Collaborator Author

jpengar commented Aug 25, 2023

@rartych kind reminder to review this PR. If you don't have any comments, maybe we can just go ahead and merge it.

@jpengar
Copy link
Collaborator Author

jpengar commented Sep 22, 2023

@rartych Did you manage to check this PR?

@rartych
Copy link
Collaborator

rartych commented Sep 22, 2023

@jpengar In the meantime this issue appeared: camaraproject/Commonalities#59
I think all tend to agree to standardize test folder as:
/code/test/<.feature_files>

@jpengar
Copy link
Collaborator Author

jpengar commented Sep 22, 2023

@jpengar In the meantime this issue appeared: camaraproject/Commonalities#59
I think all tend to agree to standardize test folder as:
/code/test/<.feature_files>
@rartych changed

@jpengar
Copy link
Collaborator Author

jpengar commented Oct 9, 2023

@rartych Please, is it ok now? If you don't have any comments, we can merge it. And of course any other changes could be added later. But this PR has been open for so many weeks already. Does it make sense to you?

@rartych
Copy link
Collaborator

rartych commented Oct 9, 2023

@jpengar I am sorry for the mess: the final decision of Commonalities is:
/code/Test_definitions/
camaraproject/Template_API_Repository#1

@jpengar
Copy link
Collaborator Author

jpengar commented Oct 9, 2023

@jpengar I am sorry for the mess: the final decision of Commonalities is: /code/Test_definitions/ camaraproject/Template_Lead_Repository#1

@rartych Changed. Haha xD... No problem, I wish all problems had such an easy solution ;P

Copy link
Collaborator

@rartych rartych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@fernandopradocabrillo fernandopradocabrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpengar jpengar merged commit c67e8c8 into main Oct 9, 2023
@jpengar jpengar deleted the jpengar/test-cases-gherkin-definition branch October 9, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants