-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First version of user stories doc #10
Conversation
@bigludo7 If it is fine with u as a first version of user stories info, please approve the PR for me to be able to merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks !! it helps.
I have a couple of comments.
We need probably to clarify what is the target device - From your perspective, is it always the device where the app is running (meaning that from a device we can only prioritize the connectivity from/to this device) ? or can you imagine than from an app running on device A you can prioritize flow from router to device B, C, etc...?
If we are in this later it means than we need another endpoint to get all device connected.
Another point, don't you think that we have also a user story about retrieving current DSCP for the device?
Thanks
The expected behaviour is that the target device is the same device where the app is running. Due to this we do not need another endpoint to get all devices connected. [It is important also to mention that an endpoint that provides information about connected devices will be much more sensible and risky from Privacy point of view, and therefore we decided to not include this on the API]
Currently we do not needed. DSCP marks are removed from all WiFi Access Point every night, so the most probable baseline scenario each time a developer calls the API is that DSCP is set to CS0 unless the same developer has requested another DSCP during the same day. |
Thanks @JosueIgual for the clarification.
Thanks |
@bigludo7 Just to complete Josue's answer. We tried to keep API design as simple as possible. Considering the use case defined, having a get operation to just know the dscp set in a device does not provide so much value. Service developer does not need to perform 2 operations (a |
@bigludo7 Done. Please have a look at it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me.
Thanks
This PR address issue #9
Upload first version of user stories doc in API documentation as agreed in 24/11 follow-up meeting.
https://github.com/camaraproject/HomeDevicesQoD/blob/main/documentation/MeetingMinutes/MOM-2022-11-24.md