Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update info.description #228

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

eric-murray
Copy link
Collaborator

Purpose:

  • documentation

What this PR does / why we need it:

Updates info.description with:

Which issue(s) this PR fixes:

Fixes #None
But helps with #212 and #222

Special notes for reviewers:

Will need to revisit once multi-SIM scenario handling is standardised

Changelog input

 release-note
 - Update info.description section for user identification and multi-SIM scenario handling

Additional documentation

None

bigludo7
bigludo7 previously approved these changes Dec 5, 2024
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good for me. Indeed the multi-SIM could be updated later.

sachinvodafone
sachinvodafone previously approved these changes Dec 5, 2024
@eric-murray eric-murray dismissed stale reviews from sachinvodafone and bigludo7 via 35d4d3d December 18, 2024 10:22
@eric-murray
Copy link
Collaborator Author

I updated all YAMLs with text on multi-SIM scenario handling, and also the "identifying the device from the token" text for the device roaming API.

I had a question on identifying the device for the subscription APIs. Currently device is a required parameter of the Subscription Request. So does this mean that subscriptions can only be created with a 2-legged token? Or should device actually be optional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants