device-reachability-status & device-roaming-status: Alignment of errors with Commonalities
#183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxl2287
requested review from
eric-murray,
bigludo7,
sachinvodafone and
akoshunyadi
as code owners
maxl2287
changed the title
device-reachability-status & device-roaming-status: Alignment of errors with Commonalities
bigludo7
reviewed
Jul 8, 2024
There was a problem hiding this comment.
@maxl2287 checking with my own yaml.
Seems that the 422 with error code UNSUPPORTED_DEVICE_IDENTIFIERS is missing.
Check case 1 https://github.com/camaraproject/Commonalities/blob/main/documentation/API-design-guidelines.md#62-error-responses---device-object
sachinvodafone
approved these changes
Jul 8, 2024
akoshunyadi
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Alignement of errors according to Commonalities guideline.
Which issue(s) this PR fixes:
Fixes #180 #181
Special notes for reviewers:
Changelog input