-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[location-verification / geofencing]: decrease radius minimum to "1" for circle-area #285
base: main
Are you sure you want to change the base?
[location-verification / geofencing]: decrease radius minimum to "1" for circle-area #285
Conversation
…d an HTTP-422 if the area cannot be covered by the implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but hope we'll have some collision with #281 for location-verification.
Co-authored-by: Jose Luis Urien <[email protected]>
Co-authored-by: Jose Luis Urien <[email protected]>
waiting for @jlurien and @javier-carrocalabor if this could be part of Spring25 Meta Release |
Checked the potential privacy issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
This PR decreses the minimum of a circle-area radius to "1".
The provider of the API can restrict then the minimum and respond with HTTP-422 if the size of the area is to small and cannot be covered.
Which issue(s) this PR fixes:
Fixes #282
Special notes for reviewers:
Changelog input