Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error Alignement with Commonalities #276

Open
bigludo7 opened this issue Dec 8, 2024 · 4 comments · May be fixed by #281 or #283
Open

Error Alignement with Commonalities #276

bigludo7 opened this issue Dec 8, 2024 · 4 comments · May be fixed by #281 or #283
Assignees
@bigludo7
Labels
correction Spring25

Comments

@bigludo7
Copy link
Collaborator

bigludo7 commented Dec 8, 2024 •
edited
Loading

Problem description
Following Commonalities rules:

To be applied:
Error 429 must be added for location-retrieval (already present in location-verification & geofencing)
Errors 410 & 429 must be added to the callback endpoint in Geofencing
Error 409 must be added for POST /subscriptions in Geofencing

To be discussed:
Error code 500 & 503 could be removed but we need a decision for all 3 APIs for consistency
Error code 429 could be removed for GET & DELETE subscriptions in Geofencing

Expected behavior
Update yamls

Alternative solution

Additional context
@bigludo7 bigludo7 self-assigned this Dec 8, 2024
@bigludo7 bigludo7 changed the title Location Retrieval - Error Alignement with Commonalities Error Alignement with Commonalities Dec 8, 2024
@alpaycetin74
Copy link
Collaborator

Why would we remove 500 and 503 errors? There can be system level issues on the server side. Thank you.

@bigludo7
Copy link
Collaborator Author

bigludo7 commented Dec 9, 2024

Hi @alpaycetin74
See camaraproject/Commonalities#355 and discussion here: camaraproject/Commonalities#321 (comment)

@alpaycetin74
Copy link
Collaborator

I see, thank you @bigludo7

This was referenced Dec 11, 2024
Open
Open
Open
@jlurien
Copy link
Collaborator

jlurien commented Dec 12, 2024

We have to make some more alignments:

  • Schema for errors must use the new template defining the allowed values as enum
  • Adopt new errors for objects with device identiers

@jlurien jlurien linked a pull request Dec 17, 2024 that will close this issue
Open
@bigludo7 bigludo7 linked a pull request Dec 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bigludo7 bigludo7

Labels
correction Spring25
Projects
None yet
Milestone
No milestone
3 participants
@jlurien @alpaycetin74 @bigludo7