Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test cases and additional documentation updates #66

Merged
merged 15 commits into from
Aug 9, 2024

Conversation

maheshc01
Copy link
Collaborator

updated to include positive test cases as per CAMARA guidelines.
Also made few updates to documentation.

@maheshc01 maheshc01 requested a review from Kevsy as a code owner August 8, 2024 21:04
@maheshc01
Copy link
Collaborator Author

maheshc01 commented Aug 8, 2024

@Kevsy for review and merge.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filename has a typo (Connecitvity -> Connectivity)

Copy link
Collaborator

@Kevsy Kevsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the comments provided (with suggested fixes)

@Kevsy Kevsy merged commit 3a84abe into camaraproject:main Aug 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants