Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS #104

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Update CODEOWNERS #104

merged 1 commit into from
Nov 22, 2024

Conversation

urvika-v
Copy link
Contributor

Adding urvika

What type of PR is this?

Add one of the following kinds:

  • bug
  • correction
  • enhancement/feature
  • cleanup
  • documentation
  • subproject management
  • tests

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

Adding urvika
@urvika-v urvika-v requested a review from a team as a code owner November 18, 2024 17:27
@hdamker hdamker requested a review from a team November 19, 2024 17:29
@hdamker
Copy link
Contributor

hdamker commented Nov 19, 2024

@camaraproject/connectivity-insights_maintainers, it is the responsibility of the Maintainers to define the codeowners for the repository, please indicate your support with your approval. Thanks.

@hdamker
Copy link
Contributor

hdamker commented Nov 19, 2024

@urvika-v please subscribe in the meantime already to https://lists.camaraproject.org/g/sp-coi

@Kevsy
Copy link
Collaborator

Kevsy commented Nov 20, 2024

Hi @hdamker , happy to approve but I see this error in the commit:

"⚠️ This CODEOWNERS file contains errors
Unknown owner on line 8: make sure @urvika-v exists and has write access to the repository"

Please can you take a look?

@hdamker
Copy link
Contributor

hdamker commented Nov 20, 2024

Hi @hdamker , happy to approve but I see this error in the commit:

"⚠️ This CODEOWNERS file contains errors Unknown owner on line 8: make sure @urvika-v exists and has write access to the repository"

Please can you take a look?

@Kevsy the reason is that @urvika-v hasn't yet write access to the repository. But that I can grant only after I now that this PR has the support of the Maintainers. Thanks for your confirmation.

@maheshc01
Copy link
Collaborator

Hi @hdamker , happy to approve but I see this error in the commit:
"⚠️ This CODEOWNERS file contains errors Unknown owner on line 8: make sure @urvika-v exists and has write access to the repository"
Please can you take a look?

@Kevsy the reason is that @urvika-v hasn't yet write access to the repository. But that I can grant only after I now that this PR has the support of the Maintainers. Thanks for your confirmation.

This PR has my support @hdamker . have approved it.

@hdamker hdamker merged commit 140da55 into camaraproject:main Nov 22, 2024
2 checks passed
@hdamker
Copy link
Contributor

hdamker commented Nov 22, 2024

@urvika-v the updated Codeowner file will get valid as soon as you have accepted the invitation to get a member of the CAMARA Organization (and the @camaraproject/connectivity-insights_codeowners team).
cc: @Kevsy @maheshc01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants