Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carrier Billing APIs Readiness Checklist MetaRelase Fall24 #166

Merged
merged 7 commits into from
Aug 2, 2024

Conversation

PedroDiez
Copy link
Collaborator

What type of PR is this?

Add one of the following kinds:

  • documentation
  • subproject management

What this PR does / why we need it:

PR to update API readiness Checklist for Carrier Billing Family APIs
PR shows expected output for MetaRelease

Which issue(s) this PR fixes:

Fixes #163

Special notes for reviewers:

To be merged after #165 is MERGED and Issues #159, #162 are CLOSED

Changelog input

 Carrier Billing Family APIs Readiness Checklist for MetaRelease Fall24

Additional documentation

N/A

@PedroDiez PedroDiez requested a review from rartych July 15, 2024 18:44
@PedroDiez PedroDiez self-assigned this Jul 15, 2024
@PedroDiez PedroDiez added the documentation Improvements or additions to documentation label Jul 15, 2024
Copy link

github-actions bot commented Jul 15, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ OPENAPI spectral 2 0 4.05s
✅ REPOSITORY git_diff yes no 0.05s
✅ REPOSITORY secretlint yes no 1.01s
✅ YAML yamllint 2 0 0.84s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@bigludo7
Copy link
Collaborator

Thanks @PedroDiez - will wait for the required missing pieces.

@hdamker
Copy link
Contributor

hdamker commented Jul 23, 2024

Looks good to me, see two hints above.

BTW: the final updates of the table are meant to be made within the Release PR, so that the merge commit of the Release PR is the one which get tagged. Otherwise the Release PR is not complete, if the checklist will come afterwards.

PedroDiez and others added 2 commits August 1, 2024 11:40
@PedroDiez
Copy link
Collaborator Author

PedroDiez commented Aug 1, 2024

@hdamker
Intention with this PR was to have ready API readiness Checklist with M4 horizon. Given the fact that:

  • User Stories have to be updated
  • Initial Test Plan have to be provided

And be ready for M4 milestone. That was what we commented within the WG

So in this way M3 (Release Candidate PR): #167, is focused on YAML.

Therefore, should I adapt this PR to "show" the status for M3 and generate afterwards a new PR for the M4 milestone, once User Stories and Testing Plan is provided?

@hdamker
Copy link
Contributor

hdamker commented Aug 1, 2024

Therefore, should I adapt this PR to "show" the status for M3 and generate afterwards a new PR for the M4 milestone, once User Stories and Testing Plan is provided?

Yes, that is the intention from Release Management perspective ... the checklist should reflect the current status of the (pre)release. And it's ok if the User Stories and Test Definitions are "tbd" in the release candidate (the latter is an exception decided by the TSC for this release cycle).

For the following releases, e.g. the one for M4, you only need to update the few details in the checklists as part of the Release PR, no separate PR needed for that.

@PedroDiez PedroDiez requested a review from hdamker August 1, 2024 16:29
hdamker
hdamker previously approved these changes Aug 1, 2024
Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... just two comments which can also be done in the release PR.

Link to changelog will be /CHANGELOG.md, permanently :-)

@PedroDiez
Copy link
Collaborator Author

I will do in this PR as I think it needs at least RM approval to be able to be merged

@PedroDiez PedroDiez requested review from a team and hdamker August 1, 2024 17:44
Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from Release Management perspective

@hdamker
Copy link
Contributor

hdamker commented Aug 1, 2024

I will do in this PR as I think it needs at least RM approval to be able to be merged

In RM we are reviewing the checklist(s) together with the release PR.
As the checklists are now perfect, should I merge them for you? (otherwise you would one Codeowner approval).

@PedroDiez
Copy link
Collaborator Author

I will do in this PR as I think it needs at least RM approval to be able to be merged

In RM we are reviewing the checklist(s) together with the release PR. As the checklists are now perfect, should I merge them for you? (otherwise you would one Codeowner approval).

If possible, yes please, it is appreaciated if you can merge it Herbert

@hdamker hdamker merged commit de7b5f5 into main Aug 2, 2024
1 check passed
@PedroDiez PedroDiez deleted the API_readiness_checklist_update_MetaRelease_Fall24 branch October 10, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update API Readiness Checklist format and information for Meta-Release Fall24
3 participants