-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carrier Billing APIs Readiness Checklist MetaRelase Fall24 #166
Carrier Billing APIs Readiness Checklist MetaRelase Fall24 #166
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Thanks @PedroDiez - will wait for the required missing pieces. |
documentation/API_documentation/Carrier Billing Refund-API-Readiness-Checkkist.md
Outdated
Show resolved
Hide resolved
documentation/API_documentation/Carrier Billing Refund-API-Readiness-Checkkist.md
Outdated
Show resolved
Hide resolved
Looks good to me, see two hints above. BTW: the final updates of the table are meant to be made within the Release PR, so that the merge commit of the Release PR is the one which get tagged. Otherwise the Release PR is not complete, if the checklist will come afterwards. |
…diness-Checkkist.md Co-authored-by: Herbert Damker <[email protected]>
…diness-Checkkist.md Co-authored-by: Herbert Damker <[email protected]>
@hdamker
And be ready for M4 milestone. That was what we commented within the WG So in this way M3 (Release Candidate PR): #167, is focused on YAML. Therefore, should I adapt this PR to "show" the status for M3 and generate afterwards a new PR for the M4 milestone, once User Stories and Testing Plan is provided? |
Yes, that is the intention from Release Management perspective ... the checklist should reflect the current status of the (pre)release. And it's ok if the User Stories and Test Definitions are "tbd" in the release candidate (the latter is an exception decided by the TSC for this release cycle). For the following releases, e.g. the one for M4, you only need to update the few details in the checklists as part of the Release PR, no separate PR needed for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ... just two comments which can also be done in the release PR.
Link to changelog will be /CHANGELOG.md, permanently :-)
documentation/API_documentation/Carrier Billing Refund-API-Readiness-Checkkist.md
Outdated
Show resolved
Hide resolved
documentation/API_documentation/Carrier Billing-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
I will do in this PR as I think it needs at least RM approval to be able to be merged |
…diness-Checkkist.md Co-authored-by: Herbert Damker <[email protected]>
…Checklist.md Co-authored-by: Herbert Damker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from Release Management perspective
In RM we are reviewing the checklist(s) together with the release PR. |
If possible, yes please, it is appreaciated if you can merge it Herbert |
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
PR to update API readiness Checklist for Carrier Billing Family APIs
PR shows expected output for MetaRelease
Which issue(s) this PR fixes:
Fixes #163
Special notes for reviewers:
To be merged after #165 is MERGED and Issues #159, #162 are CLOSED
Changelog input
Additional documentation
N/A