second_set_of_changes_for_linter

camaraproject · Nov 12, 2024 · ba2eeb5 · ba2eeb5
1 parent cd44fa4
commit ba2eeb5
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/.gherkin-lintrc b/.gherkin-lintrc
@@ -12,7 +12,7 @@
       "Scenario": 2,
       "Step": 2,
       "Examples": 4,
-      "example": 4,
+      "example": 6, //CHANGED: From "4" to "6". Should BE of level "6" to have more indentation that the "Examples" umbrella
       "given": 4,
       "when": 4,
       "then": 4,

diff --git a/code/Test_definitions/carrier-billing-createPayment.feature b/code/Test_definitions/carrier-billing-createPayment.feature
@@ -112,7 +112,7 @@ Feature: CAMARA Carrier Billing API, v0.3 - Operation createPayment
     And the response body property "$.amountTransaction.paymentAmount.chargingMetaData.merchantIdentifier" has the same value as provided in the request body
 
   @create_payment_08_amountTransaction_paymentDetails
-  Scenario: Request 1-step payment indicating merchantIdentifier
+  Scenario: Request 1-step payment indicating paymentDetails
     Given the request body property "$.amountTransaction" is set with valid required information
     And the request body array property "$.amountTransaction.paymentAmount.paymentDetails" is set with valid information
     When the HTTP "POST" request is sent
@@ -136,7 +136,7 @@ Feature: CAMARA Carrier Billing API, v0.3 - Operation createPayment
 
   @create_payment_10_amountTransaction_phoneNumber_three_legged
   # Case using a 3-legged Access Token emitted for a specific phone number
-  Scenario: Request 1-step payment indicating phoneNumber
+  Scenario: Request 1-step payment indicating phoneNumber in 3-legged access mode
     Given the request body property "$.amountTransaction" is set with valid required information
     And the request body property "$.amountTransaction.phoneNumber" is set to a valid value which is the same as associated to access token
     When the HTTP "POST" request is sent
@@ -148,7 +148,7 @@ Feature: CAMARA Carrier Billing API, v0.3 - Operation createPayment
 
   @create_payment_11_amountTransaction_phoneNumber_two_legged
   # Case using a 2-legged Access Token. Only applicable for Countries and Telco Operators whose regulation allows for it
-  Scenario: Request 1-step payment indicating phoneNumber
+  Scenario: Request 1-step payment indicating phoneNumber in 2-legged access mode
     Given the request body property "$.amountTransaction" is set with valid required information
     And the request body property "$.amountTransaction.phoneNumber" is set to a valid value
     When the HTTP "POST" request is sent

diff --git a/code/Test_definitions/carrier-billing-refund-createRefund.feature b/code/Test_definitions/carrier-billing-refund-createRefund.feature
@@ -232,7 +232,7 @@ Feature: CAMARA Carrier Billing Refund API, v0.1 - Operation createRefund
     Examples:
       | input_property          | oas_spec_schema                    |
       | $.sink                  | /components/schemas/CreateRefund   |
-      | $.sinkCredential        | /components/schemas/SinkCredential |                  |
+      | $.sinkCredential        | /components/schemas/SinkCredential |
 
   @create_refunds_400.04_required_input_properties_missing
   Scenario Outline: Required input properties are missing

diff --git a/code/Test_definitions/carrier-billing-retrievePayments.feature b/code/Test_definitions/carrier-billing-retrievePayments.feature
@@ -156,16 +156,16 @@ Feature: CAMARA Carrier Billing API, v0.3 - Operation retrievePayments
     And the response header "x-correlator" has same value as the request header "x-correlator"
     # The response has to comply with the generic response schema which is part of the spec
     And the response body complies with the OAS schema at "/components/schemas/PaymentArray"
-    And all the payments returned have their property "$.paymentStatus" == "<status>"
-    And only the payments with their property "$.paymentStatus" == "<status>" are returned
+    And all the payments returned have their property "$.paymentStatus" == "<payment_status>"
+    And only the payments with their property "$.paymentStatus" == "<payment_status>" are returned
 
     Examples:
       | payment_status     |
       | processing         |
       | pending_validation |
-      | denied             | 
-      | reserved           | 
-      | succeeded          | 
+      | denied             |
+      | reserved           |
+      | succeeded          |
       | cancelled          |
 
   @retrieve_payments_10_merchantIdentifier