Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MAINTAINERS.MD #4

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Update MAINTAINERS.MD #4

merged 2 commits into from
Dec 12, 2024

Conversation

gmuratk
Copy link
Contributor

@gmuratk gmuratk commented Dec 11, 2024

What type of PR is this?

Add one of the following kinds:

  • subproject management

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2, #1, and partially camaraproject/APIBacklog#134

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

@gmuratk gmuratk requested a review from a team as a code owner December 11, 2024 20:07
Copy link

@eharrison24 eharrison24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @gmuratk @lbertz02 and other @camaraproject/admins please review

@gmuratk gmuratk self-assigned this Dec 11, 2024
Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have invited @lbertz02 to @camaraproject/capabilities-and-runtime-restrictions_codeowners and @camaraproject/capabilities-and-runtime-restrictions_maintainers. As soon as the invite is accepted the CODEOWNERS file will get valid and we are good to go to merge.

@lbertz02
Copy link

I approved both changes.

@hdamker
Copy link
Contributor

hdamker commented Dec 12, 2024

I approved both changes.

Thanks @lbertz02, one approval for the PR would have been enough 😄
Seen that the CODEOWNERS file is now valid, so we are good to go here.

@lbertz02
Copy link

I like to emphasize what I approve and don't approve of file by file ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Maintainers.md file
4 participants