Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring25-v1 #117

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Spring25-v1 #117

merged 3 commits into from
Dec 17, 2024

Conversation

FabrizioMoggio
Copy link
Collaborator

@FabrizioMoggio FabrizioMoggio commented Dec 17, 2024 •
edited
Loading

  • State terminology not user friendly
  • Commonalities release number

What type of PR is this?

  • correction
  • update

What this PR does / why we need it:

  • To improve the terminology to be more user friendly toward the developer
  • To update the release number for Commonalities

Which issue(s) this PR fixes:

#111
#118

@FabrizioMoggio
update State terminology
725552b 
State terminology not user friendly: camaraproject#111
@FabrizioMoggio FabrizioMoggio mentioned this pull request Dec 17, 2024
Closed
FabrizioMoggio and others added 2 commits December 17, 2024 10:08
@FabrizioMoggio
Commonalities release number
e088684 
Update Commonalities release number from 0.4.0 to 0.5.0: camaraproject#118
@bigludo7
Update version in line 147
e0fa4bc
bigludo7
bigludo7 reviewed Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've proposed a fix for line 147 to chanve version to vwip

FabrizioMoggio
FabrizioMoggio commented Dec 17, 2024
View reviewed changes
Copy link
Collaborator Author

@FabrizioMoggio FabrizioMoggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for line 147

@FabrizioMoggio FabrizioMoggio merged commit 9762d26 into camaraproject:main Dec 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigludo7 bigludo7 bigludo7 approved these changes

@chinaunicomyangfan chinaunicomyangfan Awaiting requested review from chinaunicomyangfan chinaunicomyangfan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FabrizioMoggio @bigludo7