Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create APIScopeEnhancement_Device_Status_network_info #72

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

Kevsy
Copy link
Contributor

@Kevsy Kevsy commented Jul 30, 2024

Originally submitted as issue #66

What type of PR is this?

Add one of the following kinds:

  • enhancement/feature

What this PR does / why we need it:

  • adds basic network information to response object: network identifiers e.g MNC/MCC, and access medium (4G, 5G, Wi-Fi, satellite etc.)

Which issue(s) this PR fixes:

Fixes #66

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

@jgarciahospital
Copy link
Collaborator

HI @Kevsy , is the proposal meant to enhance any of the current Device Status APIs? (Reachability, Roaming or their subscriptions)

If not, even when the proposal seems to be directly targeted to the Device Status family, we'll need to consider it as a new API instead of an enhancement.

@Kevsy
Copy link
Contributor Author

Kevsy commented Aug 1, 2024

is the proposal meant to enhance any of the current Device Status APIs? (Reachability, Roaming or their subscriptions)

HI @jgarciahospital , I think it could be an enhancement to Reachability, but I think that question is best answered by @NoelWirzius . Alternatively it may be preferred to be a new API, in which case I can reformat the proposal.

@jgarciahospital
Copy link
Collaborator

is the proposal meant to enhance any of the current Device Status APIs? (Reachability, Roaming or their subscriptions)

HI @jgarciahospital , I think it could be an enhancement to Reachability, but I think that question is best answered by @NoelWirzius . Alternatively it may be preferred to be a new API, in which case I can reformat the proposal.

Ok, pending to clarify final destination of the API.

Amended per API Backlog/Device Status discussion (ref Device Status [PR 158](camaraproject/DeviceStatus#158)
Copy link
Collaborator

@jgarciahospital jgarciahospital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgarciahospital
Copy link
Collaborator

PR to be merged as validated in TSC and already work-in-progress in Device Status. @camaraproject/api-backlog_maintainers can anyone review for merging?

@caubut-charter caubut-charter merged commit d4a9e30 into camaraproject:main Oct 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scope Enhancement: network info for Device Status API Family
3 participants