Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #230 #387

Closed
wants to merge 1 commit into from
Closed

fix #230 #387

wants to merge 1 commit into from

Conversation

NQNStudios
Copy link
Collaborator

The existence of a 0 in the status map was enough to make the speed icon render. Fixed #230 by checking >0

@CelticMinstrel
Copy link
Member

I am not convinced that this issue even exists. The line you changed looks like the line that's supposed to put the "normal speed" icon if you're neither hasted nor slowed, and without the change it looks like it does that, unless 7 is the wrong icon?

@NQNStudios
Copy link
Collaborator Author

It hadn't occurred to me that there would be a "normal speed" icon but I guess you're right.

staticons

This is the icon spritesheet and counting to 7 I see the one it draws.

So my fix was wrong... but I hate the normal speed icon and think it should be removed

@CelticMinstrel
Copy link
Member

Are you able to open either of the original versions of the game, downloadable from the Spiderweb website? I theoretically can, but it seems I never copied that over from my old computer so it'll be a pain to get it booted up to try it. I'd like to know whether the "normal speed" icon actually appears in the original game, or if it was something I put back in based on remembering it in Exile 2 and 3 and seeing it on the stat icons sheet.

@NQNStudios
Copy link
Collaborator Author

setting up DOSBOX-X/Windows 98 to check. This should come in handy for resolving other questions about how the orriginal worked

@NQNStudios
Copy link
Collaborator Author

Confirmed -- there is no Normal Speed icon shown in the official version on windows.

@CelticMinstrel
Copy link
Member

I wish I could check in Basilisk 2 as well, but… if it wasn't there on Windows, I guess the chances are it also wasn't there in the Mac version. I will probably check at some later point, though.

@NQNStudios
Copy link
Collaborator Author

I tried to get Basilisk 2 running on my silicon mac and my older model, and it wasn't launching.

@CelticMinstrel
Copy link
Member

Yeah, it also wasn't launching when I tried it just before posting that. I had it set up and working on the old computer, so if I can get that plugged in, I should be able to check, but that's not as easy as it sounds…

@NQNStudios
Copy link
Collaborator Author

No one will miss the "Normal Speed" icon. 😈

@CelticMinstrel
Copy link
Member

CelticMinstrel commented Aug 10, 2024

I had the sudden realization that we could just check official screenshots. Sure enough, there's no normal speed icon.

@NQNStudios
Copy link
Collaborator Author

@CelticMinstrel you can also close #230 now

CelticMinstrel added a commit that referenced this pull request Aug 28, 2024
This reintroduces the normal speed icon and opens #387
@NQNStudios NQNStudios deleted the fix230 branch September 8, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed icon shown in party window when speed is not in any abnormal state
2 participants