Fix graphics flickering/stretching on Windows #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't break the Linux behavior. |
|
I checked and this also doesn't break anything on Mac OS. |
|
These changes didn't fix the scenario and character editors, though... |
|
Would be bad practice to leave something broken in the editors when there's a known solution, so I applied the same fix to them and it worked. |
|
I think issue #59 must be related to the same underlying cause (stuffing a menu bar into an SFML window making it squish its effective viewport weirdly). So I might as well see if that's still a problem and try to fix that too. |
|
@CelticMinstrel I'm done fiddling with this one if you don't have any other changes in mind. |
|
I assume you checked that this doesn't break anything on Mac or Linux, right? |
|
Yeah I did
…On Tue, Jun 25, 2024 at 6:24 PM Celtic Minstrel ***@***.***> wrote:
I assume you checked that this doesn't break anything on Mac or Linux,
right?
—
Reply to this email directly, view it on GitHub
<#367 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AATXBKJH7YE2KRGTDKO7IKLZJIC4FAVCNFSM6AAAAABJSYZZ6OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJQGI2TKMBSHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
NQNStudios
added a commit
to NQNStudios/cboe
that referenced
this pull request
Jul 3, 2024
* DRY, standardized window top offset * handle_splash_events() handle multiple events per frame * accurate windows menubar height for multiple rows * Windows filter a resize event triggered by the menubar * windows expand small window to fit menubar * splash screens draw in view rect, not window rect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #366
This bug was unbelievably hard to track down and fix.
I think it was probably caused by a change in SFML's code for handling window resize events on Windows. When we add the menubar to the window by bypassing SFML and using the Windows APIs, SFML now detects that change and shrinks the logical viewport of your window without expanding the window itself to fit the menubar in it.
I updated
menuProc()to catch that first unwanted resize event and discard it. I also made the window expand to fit the menubar's additional height, handled for a rare edge case where the menubar needs more than 1 row for its buttons, and made sure the splash screens still render in the right places.I need to test this on Linux and Mac to make sure it didn't break those.