naively scale dialogs by ui scale #351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine to me, though you may want to consider putting Doesn't the main UI scaling also scale up after text? It should end up being pixellated rather than blurry, though. |
Closed
I don't think there are any that don't use the Dialog class, and as for subclasses, I'm pretty sure there aren't any. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a naive solution to #350, dialog scaling. It just scales up the dialog after drawing text (so it looks blurry), and divides mouse coordinates by scale so you can still click on everything.
It could definitely have bugs in edge cases of subclasses of Dialog, or if any dialogs don't use the Dialog class, some windows won't be fixed.