-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat icp proxy #993
Merged
Merged
Feat icp proxy #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding and setting up contract for tests
…hods, fixed FunctionCall and tests
miraclx
reviewed
Dec 2, 2024
miraclx
approved these changes
Dec 3, 2024
miraclx
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ICP Proxy Contract Implementation
Summary
This PR implements the Internet Computer (ICP) version of the proxy contract, enabling multi-signature management of cross-canister calls and contract administration.
Key Features
Changes
Core Implementation
ICSignerId
,ICProposalId
ICProposal
,ICProposalAction
ICRequest
,ICRequestKind
Integration Tests
Added comprehensive test suite covering:
Build and Test Instructions
Prerequisites
cargo add candid-extractor
Build and Test Process
Prerequisites
sh -ci "$(curl -fsSL https://internetcomputer.org/install.sh)"
proxy-contract
directorychmod +x pocket-ic
Mock Contracts
The project includes mock contracts for testing purposes:
Mock Ledger Contract (`mock/ledger`):
Mock External Contract (`mock/external`):
Build Process
This script:
This script:
Running Tests
To run the integration tests:
cargo test --test integration -- --nocapture
Test Structure
The integration tests cover:
Notes