-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Context and Proxy Starknet contract integration into Calimero #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xilosada
reviewed
Nov 22, 2024
xilosada
reviewed
Nov 22, 2024
xilosada
reviewed
Nov 22, 2024
miraclx
reviewed
Nov 22, 2024
crates/context/config/src/client/env/config/query/application.rs
Outdated
Show resolved
Hide resolved
…ng the block to pending
miraclx
reviewed
Nov 26, 2024
crates/context/config/src/client/env/config/query/application.rs
Outdated
Show resolved
Hide resolved
crates/context/config/src/client/env/config/query/application.rs
Outdated
Show resolved
Hide resolved
miraclx
approved these changes
Nov 26, 2024
crates/context/config/src/client/env/config/query/privileges.rs
Outdated
Show resolved
Hide resolved
Comment on lines
36
to
39
let felt_pair: FeltPair = self.context_id.into(); | ||
let mut call_data = CallData::default(); | ||
felt_pair.encode(&mut call_data)?; | ||
Ok(call_data.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
crates/context/config/src/client/env/proxy/query/proposal_approvals.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate Starknet Blockchain integration into Calimero
Summary
Implemented logic for communicating with Starknet smart contracts (both Context and Proxy contracts).
The implementation was done based on NEAR integration. For some cases we needed to include custom logic for casting from NEAR to Starknet and vice versa.
Test plan
Setup of devnet environment and preparation of contracts can be found in these two repositories:
Context contract
Proxy contract
--protocol starknet
Config.toml
file in node directory and adjust the values there to use devnet environment.context.config.signer
use
value toself
Setup Demo Blockchain application
Repository
In first node install application wasm, create context, then initalize one more node on different ports, and add that node to context created in first node.
Steps are explained here
Start Demo blockchain app frontend, connect to nodes through Admin Dashboard
Create demo proposal and approve proposal on different node
Results should be visible on both nodes