chore: run only rust tests affected with changed files #928
Conversation
MatejVukosav
force-pushed
the
chore--run-only-rust-tests-affected-with-changed-files
branch
from
440184f to
3282a2b
Compare
MatejVukosav
force-pushed
the
chore--run-only-rust-tests-affected-with-changed-files
branch
4 times, most recently
from
0f30db8 to
607c923
Compare
MatejVukosav
force-pushed
the
chore--run-only-rust-tests-affected-with-changed-files
branch
from
607c923 to
d55637c
Compare
…-run-only-rust-tests-affected-with-changed-files
MatejVukosav
force-pushed
the
chore--run-only-rust-tests-affected-with-changed-files
branch
from
10b935e to
3a1392f
Compare
MatejVukosav
deleted the
chore--run-only-rust-tests-affected-with-changed-files
branch
There was a problem hiding this comment.
A lot of the crates don't compile on their own, for example calimero-server, calimero-node-primitives, calimero-config etc, relying instead for merod & meroctl to maximally define all the minimum feature requirements to satisfy all the crates.
Not an ideal situation, but quite the effort to untangle. It's tracked by #265 under
cargo checkto ensure theHEADbuilds right
- We need to walk the dep tree, creating a dependency graph and build each crate in order of dependence so we can guarantee all crates build independently as well as when linked. (See fix: handle outcome sender errors in the node and JSONRPC server #258 (comment))
- Don't forget to build examples
This PR attempts to test each crate independently, it will break in cases where cargo build for a specific crate doesn't work.
if mode is not "all", this will not test apps and contracts? they don't have calimero- prefix, nor are they in crates/* folder.
We should revert this.
| # Remove duplicates | ||
| unique_changed_crates=() | ||
| for item in "${changed_crates[@]}"; do | ||
| # Check if item is already in unique_array | ||
| duplicate=false | ||
| for unique_item in "${unique_changed_crates[@]}"; do | ||
| if [[ "$item" == "$unique_item" ]]; then | ||
| duplicate=true | ||
| break | ||
| fi | ||
| done | ||
| # If item is not a duplicate, add it to unique_array | ||
| if ! $duplicate; then | ||
| unique_changed_crates+=("$item") | ||
| fi | ||
| done | ||
| echo "Unique crates from changed files" "${unique_changed_crates[@]}" |
| # get list of all dependencies from the crate including external dependencies | ||
| dependencies=($(cargo metadata --format-version=1 --no-deps | jq -r --arg CRATE "$calimero_package_name" ' | ||
| .packages[] | | ||
| select(.dependencies | any(.name == $CRATE)) | | ||
| .name | ||
| ')) | ||
|
|
||
| for dep in "${dependencies[@]}"; do | ||
| # Compare dependency with list of crates from workspace to skip external dependencies | ||
| calimero_dep_crate_path="${dep/calimero-/crates/}" | ||
| for crate in "${all_crates[@]}"; do | ||
| if [[ "$crate" == "$calimero_dep_crate_path" ]]; then | ||
| echo "Found matching dependency: $calimero_dep_crate_path" | ||
| dep_arr+=("$calimero_dep_crate_path") | ||
| fi | ||
| done | ||
| done |
There was a problem hiding this comment.
we shouldn't need to test dependencies of changed crates, but "dependents" of changed crates.
calimero-node depends on calimero-context which depends on calimero-primitives, if calimero-context changes we need to test that as well as calimero-node, but not necessarily calimero-primitives
There was a problem hiding this comment.
It tests dependencies which imports changed crate
| crate_package_name=("${crate/crates\//calimero-}") | ||
| if [[ "$crate_package_name" == "calimero-merod" ]]; then | ||
| echo "Testing crate merod" | ||
| cargo +nightly test -p "merod" |
This reverts commit 1ff1351.
Tested with changed files
https://github.com/calimero-network/core/actions/runs/11698775125
./scripts/test.sh now accepts --all or --local {changed_files}Docs calimero-network/calimero-network.github.io#48