Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement context invite & identity new command #918

Merged
merged 4 commits into from
Nov 1, 2024
Merged

feat: implement context invite & identity new command #918

merged 4 commits into from
Nov 1, 2024

Conversation

fbozic
Copy link
Member

@fbozic fbozic commented Nov 1, 2024 •
edited
Loading

  • implement missing commands in the meroctl for the e2e tests
    • context invite
    • identity generate
  • cleanup up server admin primitives
    • force camelCase on all request/response types
    • expose new method only on Response types, not ResponseData types

I'm pretty certain this will break some node-ui since I've enforced camelCase on all request/response types

@fbozic fbozic self-assigned this Nov 1, 2024
@fbozic fbozic changed the title feat: implement context invite meroctl command, cleanup admin primitives feat: implement context invite command, cleanup admin primitives Nov 1, 2024
@fbozic fbozic changed the title feat: implement context invite command, cleanup admin primitives feat: implement context invite & identity new command, cleanup admin primitives Nov 1, 2024
@fbozic fbozic changed the title feat: implement context invite & identity new command, cleanup admin primitives feat: implement context invite & identity new command Nov 1, 2024
chefsale
chefsale approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@chefsale chefsale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

miraclx
miraclx reviewed Nov 1, 2024
View reviewed changes
Cargo.lock Outdated Show resolved Hide resolved
crates/server-primitives/src/admin.rs Show resolved Hide resolved
@fbozic fbozic mentioned this pull request Nov 1, 2024
Open
@fbozic fbozic merged commit 6edbe82 into master Nov 1, 2024
15 of 17 checks passed
@fbozic fbozic deleted the feat/meroctl/context-invite branch November 1, 2024 16:55
@MatejVukosav
Copy link
Member

Did u test admin dashboard after changes?

@chefsale
Copy link
Member

chefsale commented Nov 1, 2024

Needs fixing in node-ui and sdk

https://github.com/calimero-network/core/blob/master/packages/calimero-sdk/src/api/nodeApi.ts
https://github.com/calimero-network/core/blob/master/node-ui/src/api/dataSource/NodeDataSource.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miraclx miraclx miraclx left review comments

@chefsale chefsale chefsale approved these changes

@MatejVukosav MatejVukosav Awaiting requested review from MatejVukosav

Assignees

@fbozic fbozic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fbozic @MatejVukosav @chefsale @miraclx