feat(context-client): generalize implementation #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petarjuki7
requested review from
danwilliams,
alenmestrov,
miraclx and
frdomovic
miraclx
reviewed
Oct 31, 2024
chefsale
reviewed
Nov 1, 2024
petarjuki7
commented
Nov 1, 2024
xilosada
reviewed
Nov 2, 2024
| @@ -0,0 +1,2 @@ | |||
| pub mod config; | |||
| // pub mod proxy; | |||
There was a problem hiding this comment.
I removed this to reduce the scope of the PR, crates/context/config/src/client/env/proxy.rs should be addressed independently
| @@ -0,0 +1,101 @@ | |||
| use crate::client::protocol::near::Near; | |||
There was a problem hiding this comment.
I left the file just for future reference
miraclx
approved these changes
Nov 2, 2024
miraclx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of refactoring of the contract clients
This does not compile yet