Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(server): cleanup all rust warnings #396

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

fbozic
Copy link
Member

@fbozic fbozic commented Jun 19, 2024

Summary by CodeRabbit

  • Refactor
    • Updated function parameters in get_context_users_handler to use placeholder variable names for improved readability.
    • Removed import of store_client_key and updated import of add_root_key in root_keys.rs.
    • Restructured routing setup in service.rs to centralize handler references within the handlers module for better organization.
    • Removed serialization of root_key to JSON using serde_json in the add_root_key function in root_key.rs.

@fbozic fbozic self-assigned this Jun 19, 2024
Copy link

coderabbitai bot commented Jun 19, 2024

Walkthrough

The restructuring of the admin module in the server codebase involved organizing handlers into their respective modules, enhancing maintainability. Additionally, parameter placeholder names were introduced to improve code clarity.

Changes

File Summary
context.rs Updated get_context_users_handler parameters with placeholder variable names.
root_keys.rs Removed store_client_key import, updated add_root_key import in root_keys.rs.
service.rs Refactored routing setup, moving various handlers to their corresponding modules.
root_key.rs Removed serde_json serialization in add_root_key function.

Poem

In code's dance, a rabbit leaps,
Restructuring paths, the server keeps,
Handlers now in cozy homes,
Serialization's burden foams,
CodeRabbit hops, in joy it beeps! 🐇🌟


Note

Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@fbozic fbozic requested review from MatejVukosav and frdomovic June 19, 2024 12:39
@fbozic
Copy link
Member Author

fbozic commented Jun 19, 2024

No more warnings for node

❯ cargo check -p calimero-node --release
    Checking calimero-identity v0.1.0 (/Users/filipbozic/workspace/p2p/core/crates/identity)
    Checking calimero-server v0.1.0 (/Users/filipbozic/workspace/p2p/core/crates/server)
    Checking calimero-node v0.1.0 (/Users/filipbozic/workspace/p2p/core/crates/node)
    Finished release [optimized] target(s) in 3.08s

@fbozic fbozic merged commit d25b519 into master Jun 20, 2024
12 checks passed
@fbozic fbozic deleted the chore/server-warnings branch June 20, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants