Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch(meroctl): remove unnecessary commands #1059

Closed
wants to merge 2 commits into from

Conversation

petarjuki7
Copy link
Member

@petarjuki7 petarjuki7 commented Jan 27, 2025

Meroctl patch

Remove unused commands in meroctl. Changed the name of context get context command to context get info.

Test plan

Verified that the context get info command works.
Command:
cargo run -p meroctl -- --node-name node_test_1 context get 12VETuEJH5THLhe25vBWCKmCp2TLs25x6bnZuuQCDpuo (context_id) info

Documentation update

Docs for context get commands should be updated.

@petarjuki7 petarjuki7 self-assigned this Jan 27, 2025
@petarjuki7 petarjuki7 enabled auto-merge (squash) January 27, 2025 18:40
@frdomovic
Copy link
Member

Screenshot 2025-01-28 at 10 35 27

What am I missing here? I tried build from source or use merod both return this error.

cc @miraclx @petarjuki7

@frdomovic
Copy link
Member

Screenshot 2025-01-28 at 10 35 27 What am I missing here? I tried build from source or use merod both return this error.

cc @miraclx @petarjuki7

This happens when broken .wasm file is trying to be installed FYI.

Screenshot 2025-01-28 at 10 38 09

Guess this output is okay @petarjuki7

@petarjuki7 petarjuki7 disabled auto-merge January 28, 2025 10:07
@miraclx
Copy link
Member

miraclx commented Jan 28, 2025

Screenshot 2025-01-28 at 10 35 27 What am I missing here? I tried build from source or use merod both return this error.

cc @miraclx @petarjuki7

looks like a non-calimero app?

This happens when broken .wasm file is trying to be installed FYI.

yeah

@petarjuki7 petarjuki7 force-pushed the petarjuki7/meroctl-patch branch from 5b3dc1e to 969f07d Compare January 28, 2025 11:07
@petarjuki7 petarjuki7 force-pushed the petarjuki7/meroctl-patch branch from ef675a2 to 6cfce86 Compare January 28, 2025 11:23
Copy link

E2E tests report

Scenario: kv-store

Protocol/Step 0. app install (AllMembers) 1. ctx create 2. call (set, Inviter) 3. call (get, Inviter) 4. ctx invite-join 5. call (get, AllMembers)
icp
near

@petarjuki7
Copy link
Member Author

Updated PR is here, closing this one : #1060

@petarjuki7 petarjuki7 closed this Jan 28, 2025
@petarjuki7 petarjuki7 deleted the petarjuki7/meroctl-patch branch January 28, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants