Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(e2e-tests): support protocol test matrix, implement icp protocol #1035

Merged
merged 13 commits into from
Jan 16, 2025
Merged

feat(e2e-tests): support protocol test matrix, implement icp protocol #1035

merged 13 commits into from
Jan 16, 2025

Conversation

fbozic
Copy link
Member

@fbozic fbozic commented Jan 10, 2025 •
edited
Loading

  • extend e2e tests to support protocol matrix
  • run each scenario against each protocol
  • reuse deploy_devnet.sh script to setup icp localnet
    • requires candid-extractor which slows down the build [help needed]
  • generate random port numbers

@fbozic fbozic force-pushed the feat/e2e-tests-protocol-matrix branch 16 times, most recently from 7e8a0ca to bb890ce Compare January 10, 2025 19:13
@github-actions GitHub Actions
Copy link

Scenario: kv-store

Protocol/Step ApplicationInstall ContextCreate JsonRpcCall ContextInviteJoin
icp Success Success Success Success
near Success Success Success Success

@fbozic fbozic force-pushed the feat/e2e-tests-protocol-matrix branch from bb890ce to d9aa3f6 Compare January 10, 2025 19:30
@github-actions GitHub Actions
Copy link

Scenario: kv-store

Protocol/Step ApplicationInstall ContextCreate JsonRpcCall ContextInviteJoin
near ✅ ✅ ✅ ✅
icp ✅ ✅ ✅ ✅

@fbozic fbozic force-pushed the feat/e2e-tests-protocol-matrix branch from d9aa3f6 to d1e3968 Compare January 10, 2025 21:49
@github-actions GitHub Actions
Copy link

E2E tests report

Scenario: kv-store

Protocol/Step 0. ApplicationInstall 1. ContextCreate 2. JsonRpcCall 3. JsonRpcCall 4. ContextInviteJoin 5. JsonRpcCall
icp ✅ ✅ ✅ ✅ ✅ ✅
near ✅ ✅ ✅ ✅ ✅ ✅

@fbozic fbozic force-pushed the feat/e2e-tests-protocol-matrix branch 2 times, most recently from 9da15df to 4ba6211 Compare January 10, 2025 22:35
@github-actions GitHub Actions
Copy link

E2E tests report

Scenario: kv-store

Protocol/Step 0. app install (AllMembers) 1. ContextCreate 2. call (set, Inviter) 3. call (get, Inviter) 4. ctx invite-join 5. call (get, AllMembers)
icp ✅ ✅ ✅ ✅ ✅ ✅
near ✅ ✅ ✅ ✅ ✅ ✅

1 similar comment
@github-actions GitHub Actions
Copy link

E2E tests report

Scenario: kv-store

Protocol/Step 0. app install (AllMembers) 1. ContextCreate 2. call (set, Inviter) 3. call (get, Inviter) 4. ctx invite-join 5. call (get, AllMembers)
icp ✅ ✅ ✅ ✅ ✅ ✅
near ✅ ✅ ✅ ✅ ✅ ✅

@fbozic fbozic force-pushed the feat/e2e-tests-protocol-matrix branch 2 times, most recently from 34e3bd3 to cd75991 Compare January 10, 2025 22:48
@github-actions GitHub Actions
Copy link

E2E tests report

Scenario: kv-store

Protocol/Step 0. app install (AllMembers) 1. ctx create 2. call (set, Inviter) 3. call (get, Inviter) 4. ctx invite-join 5. call (get, AllMembers)
near ✅ ✅ ✅ ✅ ✅ ✅
icp ✅ ✅ ✅ ✅ ✅ ✅

@fbozic fbozic marked this pull request as ready for review January 14, 2025 11:51
@fbozic fbozic requested review from miraclx and alenmestrov January 14, 2025 11:51
@fbozic fbozic force-pushed the feat/e2e-tests-protocol-matrix branch from cd75991 to 5c7ab8a Compare January 14, 2025 11:51
@fbozic fbozic self-assigned this Jan 14, 2025
miraclx
miraclx reviewed Jan 14, 2025
View reviewed changes
e2e-tests/src/driver.rs Outdated Show resolved Hide resolved
e2e-tests/src/driver.rs Outdated Show resolved Hide resolved
e2e-tests/src/output.rs Outdated Show resolved Hide resolved
e2e-tests/src/driver.rs Outdated Show resolved Hide resolved
e2e-tests/src/driver.rs Outdated Show resolved Hide resolved
e2e-tests/src/driver.rs Outdated Show resolved Hide resolved
e2e-tests/src/driver.rs Outdated Show resolved Hide resolved
.github/workflows/e2e_tests.yml Show resolved Hide resolved
@fbozic fbozic requested a review from miraclx January 15, 2025 14:28
@fbozic fbozic force-pushed the feat/e2e-tests-protocol-matrix branch from 3111bfc to 0a06384 Compare January 15, 2025 14:37
@fbozic fbozic force-pushed the feat/e2e-tests-protocol-matrix branch from 0a06384 to e8703c0 Compare January 15, 2025 14:41
@github-actions GitHub Actions
Copy link

E2E tests report

Scenario: kv-store

Protocol/Step 0. app install (AllMembers) 1. ctx create 2. call (set, Inviter) 3. call (get, Inviter) 4. ctx invite-join 5. call (get, AllMembers)
near ✅ ✅ ✅ ✅ ✅ ✅
icp ✅ ✅ ✅ ✅ ✅ ✅

@fbozic fbozic merged commit c81ca88 into master Jan 16, 2025
11 checks passed
@fbozic fbozic deleted the feat/e2e-tests-protocol-matrix branch January 16, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miraclx miraclx miraclx approved these changes

@alenmestrov alenmestrov Awaiting requested review from alenmestrov

Assignees

@fbozic fbozic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbozic @miraclx