fix(node+contracts): remove gas, option to update proxy contract, proposal approvals #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frdomovic
changed the title
frdomovic
requested review from
miraclx,
MatejVukosav,
xilosada and
petarjuki7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(node+contracts): remove gas, option to update proxy contract, proposal approvals
Summary
In this PR gas field was removed from all structs. This is needed in order to make Blockchain demo application work.
Also proposal approval logic is updated as before it still needed 2 approvals even if threshold was set to 1 because creator approval was not included
#Tests:
Tested with ICP dev net, custom greet smart contract deployed ICP and blockchain demo application to execute cross contract call to custom contract.