Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-gcs #3

Merged
merged 1 commit into from
Sep 28, 2023
Merged

add-gcs #3

merged 1 commit into from
Sep 28, 2023

Conversation

lruizcalico
Copy link
Collaborator

@lruizcalico lruizcalico commented Sep 15, 2023

Description of your changes

  1. refactor hound_snp to add gcs functionalities
  2. change outdated BatchNormalization
  3. add .upper() to ref snp check

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation add / update

(If applicable) How has this been tested?

tested locally with local files and also gcs files
tested on google composer

@davek44
Copy link
Collaborator

davek44 commented Sep 15, 2023

In my snpclust pull request, I changed the name of 'calculate_sad' to 'score_snps'. I also added a new "-c" option that specifies SNP clustering behavior. We'll want access to that for the cloud pipeline.

davek44 pushed a commit that referenced this pull request Sep 16, 2023
reformatted with black
@lruizcalico lruizcalico merged commit 40b5c04 into main Sep 28, 2023
4 checks passed
@lruizcalico lruizcalico deleted the add-gcs branch October 26, 2023 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants