Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snp test #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

snp test #1

wants to merge 2 commits into from

Conversation

davek44
Copy link
Collaborator

@davek44 davek44 commented Sep 8, 2023

Description of your changes

This is an example integration test. It takes a few minutes to run and depends on local files. How should we handle these?

@davek44 davek44 requested a review from lruizcalico as a code owner September 8, 2023 01:34
@lruizcalico
Copy link
Collaborator

Hi Dave, do you want to have this test integrated to the external facing package or only for the internal one?

@nalien-calico
Copy link

Hi Dave,

How large are the files required to run the integration tests? We can approach this in a few ways. See below.

  1. Commit test dataset into the repo, copy them into the dockerfile and run with gihub actions
  2. Upload the test dataset onto a GCS bucket. Build a dockerfile, download test data from GCS bucket and run with github actions.
  3. Dynamically create a test dataset as a fixture in memory. Build a dockerfile and run with github actions.

@davek44
Copy link
Collaborator Author

davek44 commented Sep 11, 2023

In this case, one data file is pretty small. I added it into the github. The other data file is a human genome sequence in FASTA format. It's 3 GB unzipped. How should we handle that?

@nalien-calico
Copy link

In this case, one data file is pretty small. I added it into the github. The other data file is a human genome sequence in FASTA format. It's 3 GB unzipped. How should we handle that?

Since one of the data files is that large, I think it makes sense to have all the data stored in a GCS bucket. That way, we can just download all the data together from GCS bucket when we run the integration tests, rather than trying to pull multiple data files from different sources.

Is the test example in this PR the actual test you want to run? If not, can you provide the integration tests and test files so I can start putting a github action workflow together?

@davek44
Copy link
Collaborator Author

davek44 commented Sep 14, 2023

Yes, this is the actual test. Once we have a framework, I'll begin adding more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants