-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Default number of recurring event occurrences should be configurable #18600
base: main
Are you sure you want to change the base?
feat: Default number of recurring event occurrences should be configurable #18600
Conversation
@Amit91848 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (01/11/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (01/11/25)1 label was added to this PR based on Keith Williams's automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why can't we just set the recurring occurenceCount to minimum of occurenceCount, event.recurringEvent.count
while occurentCount having default value 1.
state.occurenceCount || 1,
setOccurenceCount(Math.min(occurenceCount, event.recurringEvent.count));
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left comments
@Amit91848 Can you please address the comments and we can then proceed to get this merged in 🙏 |
@Amit91848 are you able to address the requested changes and get this merged? My team is waiting on this functionality. If not please respond so we or someone else can take it over. |
What does this PR do?
Recording.2025-01-11.130958.mp4
Mandatory Tasks (DO NOT REMOVE)